Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AclOrch] add validation for check CRM #1082

Merged
merged 4 commits into from
Jan 17, 2020
Merged

[AclOrch] add validation for check CRM #1082

merged 4 commits into from
Jan 17, 2020

Conversation

chaoskao
Copy link
Contributor

@chaoskao chaoskao commented Oct 4, 2019

What I did
add CRM validation
Why I did it

How I verified it
run test case
Details if related

daall
daall suggested changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@daall daall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving this test! :) See comments.

tests/mock_tests/aclorch_ut.cpp Show resolved Hide resolved
tests/mock_tests/aclorch_ut.cpp Outdated Show resolved Hide resolved
tests/mock_tests/aclorch_ut.cpp Outdated Show resolved Hide resolved
tests/mock_tests/aclorch_ut.cpp Outdated Show resolved Hide resolved
tests/mock_tests/aclorch_ut.cpp Outdated Show resolved Hide resolved
tests/mock_tests/aclorch_ut.cpp Outdated Show resolved Hide resolved
daall
daall reviewed Nov 22, 2019
View reviewed changes
tests/mock_tests/aclorch_ut.cpp

//
// for each ACL TABLE with rule count larger than one => it shoule exist a corresponding entry in CRM_ACL_ENTRY and CRM_ACL_COUNTER
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd get rid of the empty comment lines (here and up above) just to be consistent with the rest of the file.

chaoskao and others added 2 commits December 2, 2019 09:56
@chaoskao @daall
Update tests/mock_tests/aclorch_ut.cpp
d72693b 
Co-Authored-By: Danny Allen <daall@microsoft.com>
@chaoskao
remove code block
e47bf3b
@daall
Copy link
Contributor

daall commented Dec 2, 2019

retest this please

1 similar comment
@daall
Copy link
Contributor

daall commented Dec 2, 2019

retest this please

@chaoskao
Copy link
Contributor Author

chaoskao commented Dec 5, 2019

@daall any problem?

daall
daall approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@daall daall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for improving this test! :)

@daall
Copy link
Contributor

daall commented Dec 6, 2019

retest this please

3 similar comments
@daall
Copy link
Contributor

daall commented Dec 18, 2019

retest this please

@chaoskao
Copy link
Contributor Author

retest this please

@daall
Copy link
Contributor

daall commented Jan 15, 2020

retest this please

@daall daall merged commit f24081b into sonic-net:master Jan 17, 2020
lguohan pushed a commit that referenced this pull request Jan 30, 2020
@chaoskao @lguohan
[AclOrch] add validation for check CRM (#1082)
e3af8ff
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@byu343
Support gearbox SAI_PORT_ATTR_PORT_SERDES_ID on vs (sonic-net#1082)
2585a1f 
This change is to support SAI_PORT_ATTR_PORT_SERDES_ID on the SAI for vs gearbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daall daall daall approved these changes

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

@qiluo-msft qiluo-msft Awaiting requested review from qiluo-msft

Assignees
No one assigned
Labels
Enhancement ➕ Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaoskao @daall