Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply buffer profiles: not wait till kernel net_devices are created for all physical ports #1109

Merged
merged 2 commits into from
Nov 4, 2019
Merged

Apply buffer profiles: not wait till kernel net_devices are created for all physical ports #1109

merged 2 commits into from
Nov 4, 2019

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Oct 29, 2019 •
edited
Loading

Apply buffer profiles when hardware physical ports are created

Introduce a mini state machine to track the portConfigState transition on receiving event from APPL_DB PORT_TABLE

Signed-off-by: Wenda Ni wenni@microsoft.com

What I did

Why I did it

How I verified it
On brcm dut

Cold reboot

Oct 30 03:46:13.403689 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: m_portConfigState: key PortConfigDone received, transit to state PORT_CONFIG_RECEIVED*

Oct 30 03:46:14.346703 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: m_portConfigState: transit to state PORT_CONFIG_DONE

Oct 30 03:46:14.566002 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: admin up port Ethernet112
Oct 30 03:46:14.566813 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: m_portConfigState: state PORT_CONFIG_DONE

Oct 30 03:46:14.570333 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: admin up port Ethernet116
Oct 30 03:46:14.570545 str-dx010-acs-1 ERR swss#orchagent: :- doPortTask: m_portConfigState: state PORT_CONFIG_DONE

Details if related

@wendani
Not wait till kernel net_devices are created for all physical ports to
ce9871a 
apply buffer profiles, but when hardware physical ports are created

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani changed the title Not wait till kernel net_devices are created for all physical ports to apply buffer profiles Apply buffer profiles: not wait till kernel net_devices are created for all physical ports Oct 29, 2019
@wendani
Copy link
Contributor Author

wendani commented Oct 29, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Oct 29, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Oct 29, 2019

@stepanblyschak to review

qiluo-msft
qiluo-msft approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lguohan
Copy link
Contributor

lguohan commented Oct 30, 2019

how much time saving is here?

@wendani
Copy link
Contributor Author

wendani commented Nov 1, 2019 •
edited
Loading

No significant time saving observed in cold reboot. #1109 (comment)

@lguohan lguohan merged commit bb4e19c into sonic-net:master Nov 4, 2019
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@mint570
Add retry on zmq functions if fail with EINTR. (sonic-net#1109)
e8a01a8 
Fixed sonic-net#1106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavel-shirshov pavel-shirshov pavel-shirshov left review comments

@lguohan lguohan lguohan approved these changes

@stepanblyschak stepanblyschak stepanblyschak approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wendani @lguohan @qiluo-msft @pavel-shirshov @stepanblyschak