DPB: Infra code to track dependencies on Port object #1147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasant17
changed the title
|
retest this please! |
|
do we need this? |
|
discussed with @zhenggen-xu , close it. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Fix `show queue watermark` command fail Signed-off-by: Petro Bratash <petrox.bratash@intel.com> * Fix Python3 copatible issue Signed-off-by: Petro Bratash <petrox.bratash@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added infrastructure code to track objects dependent on Port.
Why I did it
To support Dynamic PortBreakout feature, we need to support deletion of Port. But before deleting a port, we need to cleanup the objects dependent on Port. For example, VLAN members, ACL polrt list, interfaces, etc.
How I verified it
This code has been used with ACL and VLAN dependency handling code for DPB feature. PRs for those will raised soon. I have verified for both those PRs that existing VS test cases and feature related test cases pass.
Details if related
Before deleting a port, we will check if any module/feature/object is depending on port. If so, we will skip the port and pict the next one in the queue. That is until the dependency are removed, we keep looping the doPortTask. Once all dependencies are removed, we will delete the port.