[restore_neighbors.py] build arp packet with correct hwsrc and psrc #1158
Conversation
Otherwise, we can see that DUT after warm reboot sends ARP packets with management IP (10.112.71.4) $ sudo tcpdump -ni PortChannel0003 --direction out 16:33:40.572995 ARP, Request who-has 10.0.0.61 tell 10.112.71.4, length 28 All neighbors than are stil considered as STALE. Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
|
@zhenggen-xu looks like since day 1 the smac and srcip were not used for IPv4 ARP packet. Do you remember why? Do you have concern for this change? |
|
What is the test topology and where is PortChannel0003? scapy supposed to use the interfaces sip and smac when the arp was sent out. It would be helpful to understand why it was not. To add them explicitly should be fine as done in this PR, but might be good to check why, just don't want to hide any potential real issue somewhere. |
|
@zhenggen-xu test topology is T0, PortChannel0003 is there if you deploy minigraph for t0 from sonic-mgmt. |
|
retest vs please |
|
retest this please |
|
retest vs please |
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
…1158) Otherwise, we can see that DUT after warm reboot sends ARP packets with management IP (10.112.71.4) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
…1158) Otherwise, we can see that DUT after warm reboot sends ARP packets with management IP (10.112.71.4) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
…1158) Otherwise, we can see that DUT after warm reboot sends ARP packets with management IP (10.112.71.4) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
…1158) Otherwise, we can see that DUT after warm reboot sends ARP packets with management IP (10.112.71.4) Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
- What I did Add an option to force the hardware register dump with -f for show techsupport --allow-process-stop - How I did it Add an option '--allow-process-stop' to show techsupport cli command and '-a' to generate_dump script - How to verify it Perform show techsupport --allow-process-stop to collect extra hardware registers information which may require system interruption. - Previous command output (if the output of a command-line utility has changed) N/A - New command output (if the output of a command-line utility has changed) N/A
Otherwise, we can see that DUT after warm reboot sends ARP
packets with management IP (10.112.71.4)
$ sudo tcpdump -ni PortChannel0003 --direction out
16:33:40.572995 ARP, Request who-has 10.0.0.61 tell 10.112.71.4, length
28
All neighbors than are stil considered as STALE.
Signed-off-by: Stepan Blyschak stepanb@mellanox.com
What I did
Why I did it
How I verified it
Details if related