Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dvs] Refactor NAT tests to use redis polling fixtures #1220

Merged
merged 4 commits into from
Mar 23, 2020

Conversation

daall
Copy link
Contributor

@daall daall commented Mar 11, 2020

Signed-off-by: Danny Allen daall@microsoft.com

What I did
I refactored the NAT tests to use the redis polling fixtures added by #1213.

Why I did it
The NAT tests are failing intermittently due to timing issues, which is blocking PR builds.

How I verified it

daall@rainier:~/dev/sonic-swss/tests$ sudo pytest -s -vv --dvsname=vs test_nat.py
=========================================================================================== test session starts ============================================================================================
platform linux2 -- Python 2.7.17, pytest-4.6.9, py-1.8.1, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /home/daall/dev/sonic-swss/tests
plugins: flaky-3.6.1
collected 10 items                                                                                                                                                                                         

test_nat.py::TestNat::test_NatGlobalTable PASSED
test_nat.py::TestNat::test_NatInterfaceZone PASSED
test_nat.py::TestNat::test_AddNatStaticEntry PASSED
test_nat.py::TestNat::test_DelNatStaticEntry PASSED
test_nat.py::TestNat::test_AddNaPtStaticEntry PASSED
test_nat.py::TestNat::test_DelNaPtStaticEntry PASSED
test_nat.py::TestNat::test_AddTwiceNatEntry PASSED
test_nat.py::TestNat::test_DelTwiceNatStaticEntry PASSED
test_nat.py::TestNat::test_AddTwiceNaPtEntry PASSED
test_nat.py::TestNat::test_DelTwiceNaPtStaticEntry PASSED

======================================================================================== 10 passed in 53.86 seconds ========================================================================================

Details if related
Pre-refactor test results: 8/10 test runs passed, 52s average
Post-refactor test results: 10/10 test runs passed, 52s average

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall
Copy link
Contributor Author

daall commented Mar 12, 2020

retest this please

@daall
Copy link
Contributor Author

daall commented Mar 12, 2020

depends on sonic-net/sonic-buildimage#4259

@lguohan
Copy link
Contributor

lguohan commented Mar 16, 2020

retest this please

lguohan
lguohan previously approved these changes Mar 16, 2020
@daall
Copy link
Contributor Author

daall commented Mar 16, 2020

retest this please

@daall
Copy link
Contributor Author

daall commented Mar 23, 2020

retest this please

@daall daall requested a review from lguohan March 23, 2020 18:00
@daall daall merged commit 58e62d7 into sonic-net:master Mar 23, 2020
@daall daall deleted the nat_litmus_test branch March 23, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants