Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COPP_DEL_fix: op="DEL" for one trap group from SONIC is resetting all the … #1273

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

SinghMinu
Copy link
Contributor

@SinghMinu SinghMinu commented Apr 24, 2020

…trap IDs

What I did
Called hostif trap remove only for those trap IDs which belong to the trap group for which op="DEL" is set.

Why I did it
hostif trap remove was being called for all the trap IDs belonging to all trap groups. It was resetting all trap IDs to the default trap group configurations.

How I verified it
Followed below steps:
1)Loaded the COPP configuration "00-copp.config.json".
2)Verified that the rate limit and queue mapping for every trap ID is correct .
3)Loaded the below mentioned configuration (with op = "DEL") for the trap group(arp) using
swssconfig command.

[(no_arp.json)]
[
{
"COPP_TABLE:trap.group.arp": {
"trap_ids": "arp_req,arp_resp,neigh_discovery",
"trap_action":"copy",
"trap_priority":"4",
"queue": "4",
"meter_type":"packets",
"mode":"sr_tcm",
"cir":"600",
"cbs":"600",
"red_action":"drop"
},
"OP": "DEL"
}
]
4) Only the trap IDs belonging to the arp trap group are getting reset to the default trap group configuration. Rest of the trap IDs belonging to other trap groups still have their corresponding configuration.
5) All these verification are done through the ASIC CLI and sending corresponding packets.

Details if related

@SinghMinu SinghMinu changed the title COPP_DEL_fix: DEL for one trap group from SONIC is resetting all the … COPP_DEL_fix: op="DEL" for one trap group from SONIC is resetting all the … Apr 24, 2020
@SinghMinu
Copy link
Contributor Author

@lguohan : Kindly add reviewers for this PR.

Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prsunny
Copy link
Collaborator

prsunny commented Jun 22, 2020

@dgsudharsan , can you please review as well based on the new changes?

@prsunny prsunny merged commit a0b6412 into sonic-net:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants