[orchagent] Add zmq sync mode flag #1505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
requires sonic-net/sonic-sairedis#711 to wrok |
|
retest vs please |
|
@shi-su Could you help review? |
shi-su
reviewed
Nov 29, 2020
orchagent/main.cpp
Outdated
| @@ -76,6 +77,7 @@ void usage() | |||
| cout << " -m MAC: set switch MAC address" << endl; | |||
| cout << " -i INST_ID: set the ASIC instance_id in multi-asic platform" << endl; | |||
| cout << " -s: enable synchronous mode" << endl; | |||
There was a problem hiding this comment.
Could you also add a message that this is being deprecated as well?
orchagent/main.cpp
Outdated
| @@ -76,6 +77,7 @@ void usage() | |||
| cout << " -m MAC: set switch MAC address" << endl; | |||
| cout << " -i INST_ID: set the ASIC instance_id in multi-asic platform" << endl; | |||
| cout << " -s: enable synchronous mode" << endl; | |||
| cout << " -z: redis communication mode (redis_async|redys_sync|zmq_sync), default: redis_async" << endl; | |||
There was a problem hiding this comment.
Seems "redys_sync" is a typo.
|
retest vs please |
|
retest vs please |
shi-su
approved these changes
Dec 6, 2020
qiluo-msft
approved these changes
Dec 6, 2020
daall
pushed a commit
to daall/sonic-swss
that referenced
this pull request
Dec 7, 2020
Added support for zmq synchronous mode flag, passed from command line to sairedis
kktheballer
pushed a commit
to kktheballer/sonic-swss
that referenced
this pull request
Dec 8, 2020
Added support for zmq synchronous mode flag, passed from command line to sairedis
kktheballer
pushed a commit
to kktheballer/sonic-swss
that referenced
this pull request
Dec 20, 2020
Added support for zmq synchronous mode flag, passed from command line to sairedis
kktheballer
added a commit
to kktheballer/sonic-swss
that referenced
this pull request
Dec 23, 2020
This reverts commit 43819da.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…c-net#1505) + added tests for 'show queue counters' CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added support for zmq synchronous mode flag, passed from command line to sairedis
Why I did it
To add easy access for zmq sync mode from command line
How I verified it
Run OA with -z flag and syncd with -z flag
Details if related