-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FDBSYNCD] Some Junk character are present in the mac and port name while config MAC in the kernel. #1549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API is delete from common library, so delete the call as well
Address the review comments
Updated based on review comments
Updated based on the comment
comment from Qi.
MAC in the kernel and due to this mac programming to kernel is failing"
Will raise a new one later |
This changes are required |
prsunny
approved these changes
Dec 16, 2020
Other PR has both the request |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…1549) - Render the flow control option in show line table - Update unit test case - Update document Signed-off-by: Jing Kan jika@microsoft.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FDBSYNCD] Added support for FDBSYNCD for EVPN as described in the PR sonic-net/SONiC#437
Some Junk character are present in the mac and port name while config MAC in the kernel.
What I did
With the review comment fix one place memset was removed due to this MAC and port name is containing trailing junk character. Due to this MAC and port name has some Junk character. Due to this Junk char Kernel is returning error.
Why I did it
Fix the issue of MAC installation into the kernel
How I verified it
Verified using vsonic
Signed-off-by: Kishore Kunal kishore.kunal@broadcom.com