Add SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS counter, create new FlexCounter group #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@neethajohn, could you you please review? |
This was referenced Jan 15, 2021
|
@neethajohn if this is needed for 201911 please add the proper label |
neethajohn
reviewed
Jan 21, 2021
ayurkiv-nvda
force-pushed
the
ingress_pg_flex_azure
branch
from
67c121d
to
f267cbc
Compare
|
@neethajohn could you please review recent changes? |
No unit tests have been added. Please add |
tests in "tests/test_drop_counters.py" are different. We do not expect dynamic creation and deletion tables in this functionality. |
…ew FlexCounter group Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
ayurkiv-nvda
force-pushed
the
ingress_pg_flex_azure
branch
from
f267cbc
to
143cd28
Compare
test added |
neethajohn
approved these changes
Feb 10, 2021
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 1600 in repo Azure/sonic-swss |
ayurkiv-nvda
changed the title
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
neethajohn
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Feb 17, 2021
…er in counterpoll utility (#1355) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on: sonic-net/sonic-buildimage#6444 sonic-net/sonic-swss#1600 - What I did Added new option for "counterpoll" utility - How I did it Enhance counterpoll utility for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS Add new CLI command and extend the show command. - How to verify it To test it use QoS test. run the pfcxontest and Pfcxofftest, drop can be triggered in either of the test. It runs in ptf32 topo and requires RPC image. admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status
|
@ayurkiv-nvda can you please update the swss submodule pointer so we can move forward with the rest? |
|
@neethajohn please add label 'request for 202012' i am not able to add and this is needed. |
yxieca
pushed a commit
that referenced
this pull request
Feb 23, 2021
…ew FlexCounter group (#1600) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on : sonic-net/sonic-utilities#1355 sonic-net/sonic-buildimage#6444 What I did Added new option for "counterpoll" util Why I did it Add appropriate code to counterpoll/main.py How I verified it admin@arc-switch1041:~$ counterpoll pg-drop enable --> enable new counter admin@arc-switch1041:~$ counterpoll show --> check new PG_DROP_STAT counter status check counters admin@arc-switch1041:~$ redis-cli -n 2 127.0.0.1:6379[2]> HGETALL COUNTERS:oid:0x1a000000000062 1) "SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES" 2) "0" 3) "SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES" 4) "0" 5) "SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS" 6) "0"
yxieca
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Feb 23, 2021
…er in counterpoll utility (#1355) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on: sonic-net/sonic-buildimage#6444 sonic-net/sonic-swss#1600 - What I did Added new option for "counterpoll" utility - How I did it Enhance counterpoll utility for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS Add new CLI command and extend the show command. - How to verify it To test it use QoS test. run the pfcxontest and Pfcxofftest, drop can be triggered in either of the test. It runs in ptf32 topo and requires RPC image. admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status
anand-kumar-subramanian
pushed a commit
to anand-kumar-subramanian/sonic-utilities
that referenced
this pull request
Mar 2, 2021
…er in counterpoll utility (sonic-net#1355) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on: sonic-net/sonic-buildimage#6444 sonic-net/sonic-swss#1600 - What I did Added new option for "counterpoll" utility - How I did it Enhance counterpoll utility for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS Add new CLI command and extend the show command. - How to verify it To test it use QoS test. run the pfcxontest and Pfcxofftest, drop can be triggered in either of the test. It runs in ptf32 topo and requires RPC image. admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status
DavidZagury
pushed a commit
to DavidZagury/sonic-swss
that referenced
this pull request
Mar 4, 2021
…ew FlexCounter group (sonic-net#1600) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on : sonic-net/sonic-utilities#1355 sonic-net/sonic-buildimage#6444 What I did Added new option for "counterpoll" util Why I did it Add appropriate code to counterpoll/main.py How I verified it admin@arc-switch1041:~$ counterpoll pg-drop enable --> enable new counter admin@arc-switch1041:~$ counterpoll show --> check new PG_DROP_STAT counter status check counters admin@arc-switch1041:~$ redis-cli -n 2 127.0.0.1:6379[2]> HGETALL COUNTERS:oid:0x1a000000000062 1) "SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES" 2) "0" 3) "SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES" 4) "0" 5) "SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS" 6) "0"
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…ew FlexCounter group (sonic-net#1600) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on : sonic-net/sonic-utilities#1355 sonic-net/sonic-buildimage#6444 What I did Added new option for "counterpoll" util Why I did it Add appropriate code to counterpoll/main.py How I verified it admin@arc-switch1041:~$ counterpoll pg-drop enable --> enable new counter admin@arc-switch1041:~$ counterpoll show --> check new PG_DROP_STAT counter status check counters admin@arc-switch1041:~$ redis-cli -n 2 127.0.0.1:6379[2]> HGETALL COUNTERS:oid:0x1a000000000062 1) "SAI_INGRESS_PRIORITY_GROUP_STAT_XOFF_ROOM_WATERMARK_BYTES" 2) "0" 3) "SAI_INGRESS_PRIORITY_GROUP_STAT_SHARED_WATERMARK_BYTES" 4) "0" 5) "SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS" 6) "0"
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
…nic-net#1600) * [show][config] SNMP commands added * fixed quotes for backticks * Fixed run for runningconfiguration and Del for Delete * changed admin@switch1 to admin@sonic and removed trailing prompt * updated Usage statements for SNMP * Updated for optional and required values * updated to remove unneeded example () statements * updated typo's
|
@ayurkiv-nvda can ypu please create PR for 201911 ? Cherry-pick has conflict |
neethajohn
pushed a commit
that referenced
this pull request
Jun 22, 2022
… create new FlexCounter group (#2263) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> Appropriate PR in master #1600 What I did Added possibility to calculate Priority Group drop packet counters Why I did it Need to merge feature from master to 201911 How I verified it Setup a testbed like this: hostA - DUT – hostB, layer 2 or 3 forwarding between A/B. better to use layer 3 because by using layer 3 we can easily designate DSCP of the packet. Make sure all entries for forwarding have been correctly established, ARP, routing, neighbor, … Assume you will send traffic from A to B, start PFC storm on host B. if you are using SONiC testbed, you can start PFC storm on the fanout switch. (you can consult Volodymyr regarding how to start PFC storm) Check and update the buffer profile on the DUT’s ports connected to host A: Let’s say it’s Ethernet8, using the following command: admin@arc-mtbc-1001:~$ redis-cli -n 4 hgetall "BUFFER_PG|Ethernet8|3-4" 1) "profile" 2) "[BUFFER_PROFILE|pg_lossless_25000_5m_profile]" admin@arc-mtbc-1001:~$ redis-cli -n 4 hset "BUFFER_PROFILE|pg_lossless_25000_5m_profile" dynamic_th -8 and then save config and reload config. Send packets from host A to host B, make sure the DSCP is 3. You should be able to observe discard on PG 3 soon.
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
…er in counterpoll utility (#1355) Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com> depends on: sonic-net/sonic-buildimage#6444 sonic-net/sonic-swss#1600 - What I did Added new option for "counterpoll" utility - How I did it Enhance counterpoll utility for SAI_INGRESS_PRIORITY_GROUP_STAT_DROPPED_PACKETS Add new CLI command and extend the show command. - How to verify it To test it use QoS test. run the pfcxontest and Pfcxofftest, drop can be triggered in either of the test. It runs in ptf32 topo and requires RPC image. admin@arc-switch1041:~$ counterpoll pg-drop enable --> to enable the new counter admin@arc-switch1041:~$ counterpoll show --> check new INGRESS_PG_STAT_DROP counter status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Yurkiv ayurkiv@nvidia.com
depends on :
sonic-net/sonic-utilities#1355
sonic-net/sonic-buildimage#6444
merge priority:
#1600
sonic-net/sonic-utilities#1355
sonic-net/sonic-buildimage#6444
What I did
Added new option for "counterpoll" util
Why I did it
Add appropriate code to counterpoll/main.py
How I verified it
check counters
Details if related