[crm] Ignore unsupported switch attributes #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>
lguohan
reviewed
Jan 27, 2021
orchagent/crmorch.cpp
Outdated
| @@ -457,10 +457,14 @@ void CrmOrch::getResAvailableCounters() | |||
| sai_status_t status = sai_switch_api->get_switch_attribute(gSwitchId, 1, &attr); | |||
| if (status != SAI_STATUS_SUCCESS) | |||
| { | |||
| if(status == SAI_STATUS_NOT_SUPPORTED) | |||
| if((status == SAI_STATUS_NOT_SUPPORTED) || | |||
| (status == SAI_STATUS_ATTR_NOT_SUPPORTED_0) || | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
lguohan
reviewed
Jan 28, 2021
Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>
PrabhuSreenivasan
force-pushed
the
crm_ignore_unsupported
branch
from
611acc6 to
9b06b5e
Compare
lguohan
approved these changes
Jan 28, 2021
|
retest vs please |
lguohan
pushed a commit
that referenced
this pull request
Jan 29, 2021
Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>
DavidZagury
pushed a commit
to DavidZagury/sonic-swss
that referenced
this pull request
Mar 4, 2021
…t#1613) Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…t#1613) Signed-off-by: Prabhu Sreenivasan <prabhu.sreenivasan@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Prabhu Sreenivasan prabhu.sreenivasan@broadcom.com
Fix sonic-net/sonic-buildimage#6563
What I did
Added checks for SAI_STATUS_ATTR_NOT_SUPPORTED_0 and SAI_STATUS_ATTR_NOT_IMPLEMENTED_0 to ignore unsupported CRM attributes.
Why I did it
Switch attributes SAI_SWITCH_ATTR_AVAILABLE_SNAT_ENTRY, SAI_SWITCH_ATTR_AVAILABLE_DNAT_ENTRY and SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY are currently unsupported by some SAI implementations and below logs were appearing on those switches.
How I verified it
SWSS unit test
Details if related