Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[buffermgr] Support maximum port headroom checking" #1675

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

prsunny
Copy link
Collaborator

@prsunny prsunny commented Mar 19, 2021

Reverts #1607

Suspecting this for a test failure. Reverting to verify.

Refer: sonic-net/sonic-buildimage#6989. Failing when the PR is updated to this comment.

@lguohan
Copy link
Contributor

lguohan commented Mar 19, 2021

@stephenxs for awareness

@stephenxs
Copy link
Collaborator

From the log I see there are messages which indicate SAI returned SAI_STATUS_NOT_IMPLEMENTED the call SAI_PORT_ATTR_QOS_MAXIMUM_HEADROOM_SIZE=20 for all ports and after that SAI continued to response other calls, which means the SAI didn’t stop immediately after this call.
As this is used for dynamic buffer calculation only and that feature doesn’t run on vs image, I’m not sure that’s the reason why SAI doesn’t update the routing entries.

@prsunny prsunny merged commit acfcb85 into master Mar 21, 2021
daall pushed a commit that referenced this pull request Mar 22, 2021
prsunny added a commit that referenced this pull request Mar 25, 2021
prsunny added a commit that referenced this pull request Mar 26, 2021
yxieca pushed a commit that referenced this pull request Mar 26, 2021
@lguohan lguohan deleted the revert-1607-exceed-headroom-limit branch April 3, 2021 16:38
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…t#1675)

sonic-config-engine now depends on sonic-yang-mgmt and sonic-yang-models, so we now need to install them before we install sonic-config-engine as part of continuous integration to get the CI working again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants