-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
portsyncd: Adding ConfigDone notification in portsyncd #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stcheng
commented
Apr 25, 2016
stcheng
force-pushed
the
portconfig
branch
2 times, most recently
from
April 25, 2016 22:07
769761d
to
7861ccd
Compare
@@ -13,11 +13,14 @@ class PortsOrch : public Orch | |||
public: | |||
PortsOrch(DBConnector *db, string tableName); | |||
|
|||
inline bool isInitDone() { return m_initDone; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move all code to cpp file ?
As most of the applications depend on port initialization, we add a 'ConfigDone' notification in portsyncd after finishing reading the file 'port_config.ini'. Before orchagent receives this notification, all other tasks from other applications are stored without actually being executed. Only when the orchagent get this notification will all other tasks been executed. Signed-off-by: Shuotian Cheng <shuche@microsoft.com>
Ack |
ack |
ishidawataru
pushed a commit
to ishidawataru/sonic-swss
that referenced
this pull request
Aug 29, 2018
…dge_port_map (sonic-net#17) This will prevent snmp subagent from crashing when iterating an empty bridge port map Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
vasant17
pushed a commit
to vasant17/sonic-swss
that referenced
this pull request
Dec 13, 2019
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
samaity
added a commit
to samaity/sonic-swss
that referenced
this pull request
Dec 14, 2019
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
* Added serialization data for QOS components Signed-off-by: hrachya@mellanox.com
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.