Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portsyncd: Adding ConfigDone notification in portsyncd #17

Merged
merged 1 commit into from
Apr 29, 2016

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Apr 25, 2016

As most of the applications depend on port initialization, we add
a 'ConfigDone' notification in portsyncd after finishing reading
the file 'port_config.ini'. Before orchagent receives this notification,
all other tasks from other applications are stored without actually
being executed. Only when the orchagent get this notification will all
other tasks been executed.

Signed-off-by: Shuotian Cheng <shuche@microsoft.com>

@stcheng stcheng force-pushed the portconfig branch 2 times, most recently from 769761d to 7861ccd Compare April 25, 2016 22:07
@@ -13,11 +13,14 @@ class PortsOrch : public Orch
public:
PortsOrch(DBConnector *db, string tableName);

inline bool isInitDone() { return m_initDone; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move all code to cpp file ?

As most of the applications depend on port initialization, we add
a 'ConfigDone' notification in portsyncd after finishing reading
the file 'port_config.ini'. Before orchagent receives this notification,
all other tasks from other applications are stored without actually
being executed. Only when the orchagent get this notification will all
other tasks been executed.

Signed-off-by: Shuotian Cheng <shuche@microsoft.com>
@kcudnik
Copy link
Contributor

kcudnik commented Apr 26, 2016

Ack

@lguohan
Copy link
Contributor

lguohan commented Apr 26, 2016

ack

@stcheng stcheng merged commit f191703 into sonic-net:master Apr 29, 2016
@stcheng stcheng deleted the portconfig branch April 29, 2016 18:40
ishidawataru pushed a commit to ishidawataru/sonic-swss that referenced this pull request Aug 29, 2018
…dge_port_map (sonic-net#17)

This will prevent snmp subagent from crashing when iterating an empty bridge port map

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
vasant17 pushed a commit to vasant17/sonic-swss that referenced this pull request Dec 13, 2019
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
samaity added a commit to samaity/sonic-swss that referenced this pull request Dec 14, 2019
Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
* Added serialization data for QOS components
Signed-off-by:  hrachya@mellanox.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants