Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mux orch] Fix tunnel based NHs for IPv6 and ECMP routes #1711

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

prsunny
Copy link
Collaborator

@prsunny prsunny commented Apr 17, 2021

What I did

  1. In case of standby mux, associated routes may come to orch with ifname of tun0. Handle the case when nexthop is non-zero
  2. For ECMP, multiple nexthop IPs can have the same sai nexthop id (tunnel NH). Existing data structure is unable to handle such case. Added a secondary map if nexthops are shared
  3. VS test to cover both cases.

Why I did it
For dual tor SLB support

How I verified it

Details if related

@prsunny prsunny merged commit 9f22ba7 into sonic-net:master Apr 20, 2021
@prsunny prsunny deleted the slb branch April 20, 2021 00:08
daall pushed a commit that referenced this pull request Apr 21, 2021
*In case of standby mux, associated routes may come to orch with ifname of tun0. Handle the case when nexthop is non-zero
*For ECMP, multiple nexthop IPs can have the same sai nexthop id (tunnel NH). Existing data structure is unable to handle such case. Added a secondary map if nexthops are shared
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
*In case of standby mux, associated routes may come to orch with ifname of tun0. Handle the case when nexthop is non-zero
*For ECMP, multiple nexthop IPs can have the same sai nexthop id (tunnel NH). Existing data structure is unable to handle such case. Added a secondary map if nexthops are shared
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
Originally, the Azure pipeline "Code Coverage" page will render folder structure wrongly. The first level of folders disappear and all the files in the first level are combined and de-dup. So we lost many main.py, etc.

Fix the coveragerc file so that the rendering will make sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants