Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for in-band-mgmt via management VRF #1726

Merged
merged 36 commits into from
Jun 24, 2021

Conversation

venkatmahalingam
Copy link
Contributor

@venkatmahalingam venkatmahalingam commented Apr 26, 2021

Signed-off-by: Venkatesan Mahalingam venkatesan_mahalinga@dell.com
Please refer HLD and swss-common pull requests for more information.

What I did

Support for in-band-mgmt via management VRF

Why I did it
Other than eth0, mgmt VRF should have in-band L3 interfaces as well.

How I verified it
Verified the functionality using sonic-vs testcases

Details if related

Please refer old PR for old comments,

Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
orchagent/intfsorch.cpp Outdated Show resolved Hide resolved
orchagent/intfsorch.cpp Outdated Show resolved Hide resolved
orchagent/intfsorch.h Outdated Show resolved Hide resolved
orchagent/intfsorch.cpp Show resolved Hide resolved
orchagent/neighorch.cpp Show resolved Hide resolved
tests/test_inband_intf_mgmt_vrf.py Show resolved Hide resolved
orchagent/intfsorch.cpp Outdated Show resolved Hide resolved
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
@prsunny
Copy link
Collaborator

prsunny commented Jun 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

cfgmgr/vrfmgr.cpp Outdated Show resolved Hide resolved
cfgmgr/vrfmgr.cpp Outdated Show resolved Hide resolved
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
cfgmgr/vrfmgr.cpp Outdated Show resolved Hide resolved
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
@venkatmahalingam
Copy link
Contributor Author

/azpw run

@venkatmahalingam
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1726 in repo Azure/sonic-swss

@prsunny
Copy link
Collaborator

prsunny commented Jun 14, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

cfgmgr/vrfmgr.cpp Outdated Show resolved Hide resolved
tests/test_inband_intf_mgmt_vrf.py Outdated Show resolved Hide resolved
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
@venkatmahalingam
Copy link
Contributor Author

/azpw run

@venkatmahalingam
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 1726 in repo Azure/sonic-swss

@prsunny
Copy link
Collaborator

prsunny commented Jun 23, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@venkatmahalingam
Copy link
Contributor Author

/azpw run

@prsunny
Copy link
Collaborator

prsunny commented Jun 23, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

prsunny
prsunny previously approved these changes Jun 23, 2021
@prsunny
Copy link
Collaborator

prsunny commented Jun 24, 2021

Please add sonic-mgmt tests for covering this. I'll add a tracking issue.

@prsunny prsunny merged commit c37cc1c into sonic-net:master Jun 24, 2021
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Jun 29, 2021
Advance submodule head for sonic-swss

3226163 [BufferOrch] Don't call SAI API for BUFFER_POOL/PROFILE handling in case the op is DEL and the SAI OID is NULL (sonic-net/sonic-swss#1786)
6c88e47 [Dynamic Buffer Calc][Mellanox] Bug fixes and enhancements for the lua plugins for buffer pool calculation and headroom checking (sonic-net/sonic-swss#1781)
e86b900 [MPLS] sonic-swss changes for MPLS (sonic-net/sonic-swss#1686)
4c8e2b5 [Dynamic Buffer Calc] Avoid creating lossy PG for admin down ports during initialization (sonic-net/sonic-swss#1776)
3602124 [VS test stability] Skip flaky test for DPB (sonic-net/sonic-swss#1807)
c37cc1c Support for in-band-mgmt via management VRF (sonic-net/sonic-swss#1726)
1e3a532 Fix config prompt question issue (sonic-net/sonic-swss#1799)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Advance submodule head for sonic-swss

3226163 [BufferOrch] Don't call SAI API for BUFFER_POOL/PROFILE handling in case the op is DEL and the SAI OID is NULL (sonic-net/sonic-swss#1786)
6c88e47 [Dynamic Buffer Calc][Mellanox] Bug fixes and enhancements for the lua plugins for buffer pool calculation and headroom checking (sonic-net/sonic-swss#1781)
e86b900 [MPLS] sonic-swss changes for MPLS (sonic-net/sonic-swss#1686)
4c8e2b5 [Dynamic Buffer Calc] Avoid creating lossy PG for admin down ports during initialization (sonic-net/sonic-swss#1776)
3602124 [VS test stability] Skip flaky test for DPB (sonic-net/sonic-swss#1807)
c37cc1c Support for in-band-mgmt via management VRF (sonic-net/sonic-swss#1726)
1e3a532 Fix config prompt question issue (sonic-net/sonic-swss#1799)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021
* Support for in-band-mgmt via management VRF.

Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants