-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for in-band-mgmt via management VRF #1726
Merged
prsunny
merged 36 commits into
sonic-net:master
from
venkatmahalingam:in-band-intf-via-mgmt-vrf
Jun 24, 2021
Merged
Support for in-band-mgmt via management VRF #1726
prsunny
merged 36 commits into
sonic-net:master
from
venkatmahalingam:in-band-intf-via-mgmt-vrf
Jun 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
…intf-via-mgmt-vrf
…intf-via-mgmt-vrf
…intf-via-mgmt-vrf
…intf-via-mgmt-vrf
prsunny
reviewed
May 18, 2021
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Jun 12, 2021
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
prsunny
reviewed
Jun 12, 2021
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
prsunny
reviewed
Jun 12, 2021
/azpw run |
/azp run |
Commenter does not have sufficient privileges for PR 1726 in repo Azure/sonic-swss |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
reviewed
Jun 21, 2021
Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
/azpw run |
/azp run |
Commenter does not have sufficient privileges for PR 1726 in repo Azure/sonic-swss |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
previously approved these changes
Jun 23, 2021
prsunny
reviewed
Jun 23, 2021
prsunny
approved these changes
Jun 24, 2021
Please add sonic-mgmt tests for covering this. I'll add a tracking issue. |
4 tasks
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 29, 2021
Advance submodule head for sonic-swss 3226163 [BufferOrch] Don't call SAI API for BUFFER_POOL/PROFILE handling in case the op is DEL and the SAI OID is NULL (sonic-net/sonic-swss#1786) 6c88e47 [Dynamic Buffer Calc][Mellanox] Bug fixes and enhancements for the lua plugins for buffer pool calculation and headroom checking (sonic-net/sonic-swss#1781) e86b900 [MPLS] sonic-swss changes for MPLS (sonic-net/sonic-swss#1686) 4c8e2b5 [Dynamic Buffer Calc] Avoid creating lossy PG for admin down ports during initialization (sonic-net/sonic-swss#1776) 3602124 [VS test stability] Skip flaky test for DPB (sonic-net/sonic-swss#1807) c37cc1c Support for in-band-mgmt via management VRF (sonic-net/sonic-swss#1726) 1e3a532 Fix config prompt question issue (sonic-net/sonic-swss#1799) Signed-off-by: Stephen Sun <stephens@nvidia.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Advance submodule head for sonic-swss 3226163 [BufferOrch] Don't call SAI API for BUFFER_POOL/PROFILE handling in case the op is DEL and the SAI OID is NULL (sonic-net/sonic-swss#1786) 6c88e47 [Dynamic Buffer Calc][Mellanox] Bug fixes and enhancements for the lua plugins for buffer pool calculation and headroom checking (sonic-net/sonic-swss#1781) e86b900 [MPLS] sonic-swss changes for MPLS (sonic-net/sonic-swss#1686) 4c8e2b5 [Dynamic Buffer Calc] Avoid creating lossy PG for admin down ports during initialization (sonic-net/sonic-swss#1776) 3602124 [VS test stability] Skip flaky test for DPB (sonic-net/sonic-swss#1807) c37cc1c Support for in-band-mgmt via management VRF (sonic-net/sonic-swss#1726) 1e3a532 Fix config prompt question issue (sonic-net/sonic-swss#1799) Signed-off-by: Stephen Sun <stephens@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
* Support for in-band-mgmt via management VRF. Signed-off-by: Venkatesan Mahalingam <venkatesan_mahalinga@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Venkatesan Mahalingam venkatesan_mahalinga@dell.com
Please refer HLD and swss-common pull requests for more information.
What I did
Support for in-band-mgmt via management VRF
Why I did it
Other than eth0, mgmt VRF should have in-band L3 interfaces as well.
How I verified it
Verified the functionality using sonic-vs testcases
Details if related
Please refer old PR for old comments,