Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c] Test AZP for bug fixing #1771

Draft
wants to merge 8 commits into
base: 202012
Choose a base branch
from
Draft

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented Jun 6, 2021

What I did
Test AZP

Why I did it

How I verified it

Details if related

lguohan and others added 6 commits June 2, 2021 01:28
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
in other pipelines, they will download swss and pytests. this is make sure the swss.deb and pytests are matched.

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Observe persistent failure of newly added vs test on testing code change in intfmgrd after migrating to azure pipeline. sonic-net#1521 passed in legacy Jenkins pipeline.

What we found is that the code change in the swss compiled with PR change is not properly installed in vs docker for a direct installation using dpkg -i. This is confirmed by verifying pipeline artifacts that md5sum value of /user/bin/intfmgrd changes if we install swss deb aritfact into the docker vs artifact, while that of /usr/bin/orchangent stays unchanged.

md5sum before swss install in vs docker

# md5sum /usr/bin/orchagent
28307a7805ea6f3bc5057c0257bf46e6  /usr/bin/orchagent
 
# md5sum /usr/bin/intfmgrd  
fa2b06e20be683286adb47c55635a86d  /usr/bin/intfmgrd
md5sum after swss install

# dpkg -i swss_1.0.0_amd64.deb 
(Reading database ... 19180 files and directories currently installed.)
Preparing to unpack swss_1.0.0_amd64.deb ...
Unpacking swss (1.0.0) over (1.0.0) ...
Setting up swss (1.0.0) ...
# md5sum /usr/bin/orchagent
28307a7805ea6f3bc5057c0257bf46e6  /usr/bin/orchagent

# md5sum /usr/bin/intfmgrd 
e959340709e7aedd7489e69dfd19768f  /usr/bin/intfmgrd

Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@xumia xumia added the ci label Jun 6, 2021
@xumia xumia marked this pull request as draft June 6, 2021 09:58
@xumia
Copy link
Collaborator Author

xumia commented Jun 6, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…g on Supervisor card (sonic-net#1771)

What I did
Fixed sonic-net/sonic-buildimage#8521

How I did it
Before displaying the warning message, call device_info.is_supervisor() function to check if it is supervisor card, don't display the warning message.

How to verify it
Running the image on supervisor card
Execute the CLI "show interfaces status"
No warning should be seen.

Signed-off-by: mlok <marty.lok@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants