[buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f it is not supported by a pool Currently, SAI_BUFFER_POOL_STAT_WATERMARK_BYTES and SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES are queried for buffer pools. However, the latter is not supported on all pools and all platforms, which will results in sairedis complaint To avoid that, we need to test whether it is supported before putting it to FLEX_COUNTER table Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
The latter is not supported by all vendors Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@neethajohn kindly reminder to review this PR |
|
/azpw |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@neethajohn , could you please the code? Also, I dont think we can backport to 202012 as this might break other platforms implementations. We already had an issue backporting this PR - #1789. Hence, removing label. |
…rk polling - If shared headroom pool watermark is not supported, only buffer pool watermark will be tested - Otherwise, both buffer pool watermark and shared headroom pool watermark will be checked Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
@neethajohn fyi. both |
neethajohn
reviewed
Aug 27, 2021
Fix review comments.
neethajohn
previously approved these changes
Aug 28, 2021
qiluo-msft
reviewed
Aug 30, 2021
Signed-off-by: Stephen Sun <stephens@nvidia.com>
neethajohn
approved these changes
Aug 30, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Sep 2, 2021
…OOM_WATERMARK_BYTES on a pool where it is not supported (#1857) * [Bugfix] Don't query SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES if it is not supported by a pool Currently, SAI_BUFFER_POOL_STAT_WATERMARK_BYTES and SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES are queried for buffer pools. However, the latter is not supported on all pools and all platforms, which will results in sairedis complaint To avoid that, we need to test whether it is supported before putting it to FLEX_COUNTER table Signed-off-by: Stephen Sun <stephens@nvidia.com> How I verified it Run vstest and manually test.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
…OOM_WATERMARK_BYTES on a pool where it is not supported (sonic-net#1857) * [Bugfix] Don't query SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES if it is not supported by a pool Currently, SAI_BUFFER_POOL_STAT_WATERMARK_BYTES and SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES are queried for buffer pools. However, the latter is not supported on all pools and all platforms, which will results in sairedis complaint To avoid that, we need to test whether it is supported before putting it to FLEX_COUNTER table Signed-off-by: Stephen Sun <stephens@nvidia.com> How I verified it Run vstest and manually test.
vaibhavhd
added a commit
to vaibhavhd/sonic-swss
that referenced
this pull request
Oct 6, 2021
…T_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (sonic-net#1857)" This reverts commit 3d6b1f0.
vaibhavhd
added a commit
that referenced
this pull request
Oct 6, 2021
…T_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (#1857)" (#1945) This reverts commit 3d6b1f0. Fix sonic-net/sonic-buildimage#8893 What I did This commit had earlier caused issue on master image warmboot - sonic-net/sonic-buildimage#8722 To fix this issue, this PR was created to retreat sonic-swss head on buildimage - sonic-net/sonic-buildimage#8732 Now, this commit was again pulled into sonic-buildimage as part of sonic-swss submodule advance: sonic-net/sonic-buildimage#8839 And, warm-reboot again broke for the same reason. This change is so that any other swss submodule update on buildimage will not fail warmboot again.
judyjoseph
pushed a commit
that referenced
this pull request
Oct 7, 2021
…T_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (#1857)" (#1945) This reverts commit 3d6b1f0. Fix sonic-net/sonic-buildimage#8893 What I did This commit had earlier caused issue on master image warmboot - sonic-net/sonic-buildimage#8722 To fix this issue, this PR was created to retreat sonic-swss head on buildimage - sonic-net/sonic-buildimage#8732 Now, this commit was again pulled into sonic-buildimage as part of sonic-swss submodule advance: sonic-net/sonic-buildimage#8839 And, warm-reboot again broke for the same reason. This change is so that any other swss submodule update on buildimage will not fail warmboot again.
stephenxs
added a commit
to stephenxs/sonic-swss
that referenced
this pull request
Dec 14, 2021
…POOL_STAT_XOFF_ROOM_WATERMARK_BYTES on a pool where it is not supported (sonic-net#1857)" (sonic-net#1945)" This reverts commit 94d2d44.
stephenxs
added a commit
to stephenxs/sonic-swss
that referenced
this pull request
Jan 7, 2022
…OOM_WATERMARK_BYTES on a pool where it is not supported (sonic-net#1857) * [Bugfix] Don't query SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES if it is not supported by a pool Currently, SAI_BUFFER_POOL_STAT_WATERMARK_BYTES and SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES are queried for buffer pools. However, the latter is not supported on all pools and all platforms, which will results in sairedis complaint To avoid that, we need to test whether it is supported before putting it to FLEX_COUNTER table Signed-off-by: Stephen Sun <stephens@nvidia.com> How I verified it Run vstest and manually test.
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 24, 2022
…OOM_WATERMARK_BYTES on a pool where it is not supported (#1857) (#2106) - What I did Currently, SAI_BUFFER_POOL_STAT_WATERMARK_BYTES and SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES are queried for buffer pools. However, the latter is not supported on all pools and all platforms, which will results in sairedis complaint To avoid that, we need to test whether it is supported before putting it to FLEX_COUNTER table It depends on #1987 to be cherry-picked to 202012. - Why I did it [Bugfix] Don't query SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES if it is not supported by a pool - How I verified it Run vstest and manually test.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Added portchannels support for static routes. * Added check if nexthop is a portchannel and verify if this portchannel exists in config db. Signed-off-by: d-dashkov <Dmytro_Dashkov@Jabil.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Currently, SAI_BUFFER_POOL_STAT_WATERMARK_BYTES and SAI_BUFFER_POOL_STAT_XOFF_ROOM_WATERMARK_BYTES are queried for buffer pools.
However, the latter is not supported on all pools and all platforms, which will result in sairedis complaint like this:
To avoid that, we need to test whether it is supported before putting it to FLEX_COUNTER_DB
Signed-off-by: Stephen Sun stephens@nvidia.com
Why I did it
How I verified it
Run vstest and manually test.
Details if related