-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cfgmgr] Update Makefile.am to consume lib zmq #1864
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
202106 port: #1865 |
LGTM error not related to PR |
lguohan
approved these changes
Aug 13, 2021
5 tasks
vaibhavhd
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Aug 17, 2021
Update sonic-swss submodule to include the latest changes: Add autoconf-archive package to lgtm sonic-net/sonic-swss#1868 [cfgmgr] Update Makefile.am to consume lib zmq sonic-net/sonic-swss#1864 Fix warmboot issue PR##8367 sonic-net/sonic-swss#1866
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
New changes in sairedis repo will move zmq dependency to libsaimeta
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
#### What I did Add some logs to generic_updater #### How I did it #### How to verify it #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed) Empty patch ``` admin@vlab-01:~$ sudo config apply-patch empty.json-patch Patch Applier: Patch application starting. Patch Applier: Patch: [] Patch Applier: Validating patch is not making changes to tables without YANG models. Patch Applier: Getting current config db. Patch Applier: Simulating the target full config after applying the patch. Patch Applier: Validating target config according to YANG models. ... [logs from sonic-yang-mgmt framework] Patch Applier: Sorting patch updates. Patch Applier: The patch was sorted into 0 changes. Patch Applier: Applying changes in order. Patch Applier: Verifying patch updates are reflected on ConfigDB. Patch Applier: Patch application completed. Patch applied successfully. admin@vlab-01:~$ ``` Single change patch ``` admin@vlab-01:~$ sudo config apply-patch dhcp_add.json-patch Patch Applier: Patch application starting. Patch Applier: Patch: [{"op": "add", "path": "/VLAN/Vlan1000/dhcp_servers/4", "value": "192.0.0.5"}] Patch Applier: Validating patch is not making changes to tables without YANG models. Patch Applier: Getting current config db. Patch Applier: Simulating the target full config after applying the patch. Patch Applier: Validating target config according to YANG models. ... [logs from sonic-yang-mgmt framework] Patch Applier: The patch was sorted into 1 change: Patch Applier: * [{"op": "add", "path": "/VLAN/Vlan1000/dhcp_servers/4", "value": "192.0.0.5"}] Patch Applier: Applying changes in order. Failed to apply patch Usage: config apply-patch [OPTIONS] PATCH_FILE_PATH Try "config apply-patch -h" for help. Error: ChangeApplier.apply(change) is not implemented yet admin@vlab-01:~$ ``` Multi change patch: ``` admin@vlab-01:~$ sudo config apply-patch update_lanes.json-patch Patch Applier: Patch application starting. Patch Applier: Patch: [{"op": "replace", "path": "/PORT/Ethernet100/lanes", "value": "121,122,123"}] Patch Applier: Validating patch is not making changes to tables without YANG models. Patch Applier: Getting current config db. Patch Applier: Simulating the target full config after applying the patch. Patch Applier: Validating target config according to YANG models. ... [logs from sonic-yang-mgmt framework] Patch Applier: Sorting patch updates. ... [logs from sonic-yang-mgmt framework] Patch Applier: The patch was sorted into 2 changes: Patch Applier: * [{"op": "remove", "path": "/PORT/Ethernet100"}] Patch Applier: * [{"op": "add", "path": "/PORT/Ethernet100", "value": {"alias": "fortyGigE0/100", "description": "fortyGigE0/100", "index": "25", "lanes": "121,122,123", "mtu": "9100", "pfc_asym": "off", "speed": "40000", "tpid": "0x8100"}}] Patch Applier: Applying changes in order. Failed to apply patch Usage: config apply-patch [OPTIONS] PATCH_FILE_PATH Try "config apply-patch -h" for help. Error: ChangeApplier.apply(change) is not implemented yet admin@vlab-01:~$ ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added -lzmq flag to cfgmgr
Why I did it
New changes in sairedis repo will move zmq dependency to libsaimeta
How I verified it
Local build
Details if related