Revert "[debugcounterorch] check if counter type is supported #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…querying… (sonic-net#1789)" This reverts commit 04105a4.
|
@stepanblyschak for viz |
qiluo-msft
approved these changes
Aug 25, 2021
gechiang
approved these changes
Aug 25, 2021
|
@prsunny Is there a plan to take this change back to 202012 soon? As I understand this is platform's SAI issue. |
No, we don't have plans to take to 202012 as of now. |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
- What I did This PR include some fixes which were missed for sonic-net#1723 i.e. removing -t option from the docker exec commands. to understand why the -it option was removed, refer sonic-net#1723. Also, the show techsupport exits with $RETURN_CODE only when --redirect-stderr option is used. Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 04105a4.
What I did
Revert PR #1789 from 202012 branch.
Why I did it
Fix issue - sonic-net/sonic-buildimage#8538 in 202012 branch.
How I verified it
Details if related