[202012][PFCWD + Asym PFC]: Allow PFCWD to detect PFC storm on all pr… #1887

volodymyrsamotiy · 2021-08-26T08:55:25Z

…iorities when Asym PFC is enabled

Signed-off-by: Volodymyr Samotiy volodymyrs@nvidia.com

Same as #1360 but for 202012 since cherry-pick has merge conflicts

What I did
Add possibility for PFCWD to detect PFC storm on all priorities when asymmetric PFC is enabled.

According to requirements PFCWD should detect PFC storm on the lossy priorities for the port on which asymmetric PFC is enabled.
(when asymmetric PFC is enabled on some port that means such port is enabled for receiving PFC frames on all priorities)

Why I did it
To fix issue #1128.

How I verified it

Enable asymmetric PFC on test port.

pfc config asymmetric on <port>

Enable PFCWD on the test port.

pfcwd start --action drop --restoration-time 3000 <port> 1000
pfcwd interval 500

Run pause frames to the test port for all priorities.
Verify that PFCWD detected storm for all priorities.

pfcwd show stats

Details if related
N/A

lgtm-com · 2021-08-26T09:02:00Z

This pull request fixes 1 alert when merging 21c0f04 into 8471f42 - view on LGTM.com

fixed alerts:

1 for Unused import

liat-grozovik · 2021-08-30T19:33:45Z

@volodymyrsamotiy can you please handle LGTM error?

liat-grozovik · 2021-09-02T06:35:40Z

@volodymyrsamotiy please check LGTM failure and handle

volodymyrsamotiy · 2021-09-03T08:11:16Z

@volodymyrsamotiy please check LGTM failure and handle

It is not related to my changes.
It looks like something generic and related to build infra:

[2021-08-26 09:01:54] [build-stderr] main.cpp:2:10: fatal error: sai.h: No such file or directory
[2021-08-26 09:01:54] [build-stderr]     2 | #include "sai.h"
[2021-08-26 09:01:54] [build-stderr]       |          ^~~~~~~
[2021-08-26 09:01:54] [build-stderr] compilation terminated.
[2021-08-26 09:01:54] [build-stdout] make[2]: Leaving directory '/opt/src/orchagent'
[2021-08-26 09:01:54] [build-stderr] make[2]: *** [Makefile:623: orchagent-main.o] Error 1

lgtm-com · 2021-09-03T08:18:37Z

This pull request fixes 1 alert when merging 21c0f04 into 8471f42 - view on LGTM.com

fixed alerts:

1 for Unused import

liat-grozovik · 2021-09-03T08:23:25Z

@qiluo-msft do you have an idea how to overcome it?

liat-grozovik · 2021-09-12T11:25:45Z

@neethajohn could you please help to merge regardless of the LGM issue or you can suggest how to overcome it?

liat-grozovik · 2021-09-12T13:02:53Z

@volodymyrsamotiy it seems lgtm is not working also on 201911. please see #1901

lgtm-com · 2021-09-14T09:33:44Z

This pull request fixes 1 alert when merging 89cf1a2 into 6b0b2c4 - view on LGTM.com

fixed alerts:

1 for Unused import

…iorities when Asym PFC is enabled Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>

lgtm-com · 2021-09-14T13:37:48Z

This pull request fixes 1 alert when merging 48973be into 6b0b2c4 - view on LGTM.com

fixed alerts:

1 for Unused import

volodymyrsamotiy · 2021-09-20T10:25:09Z

/azpw run

mssonicbld · 2021-09-20T10:25:11Z

/AzurePipelines run

azure-pipelines · 2021-09-20T10:25:20Z

Azure Pipelines successfully started running 1 pipeline(s).

volodymyrsamotiy · 2021-09-27T09:19:29Z

/azpw run

mssonicbld · 2021-09-27T09:19:30Z

/AzurePipelines run

azure-pipelines · 2021-09-27T09:19:40Z

Azure Pipelines successfully started running 1 pipeline(s).

…wd_asym_pfc_202012

lgtm-com · 2021-09-27T13:10:43Z

This pull request fixes 1 alert when merging eedaf66 into ee9c30d - view on LGTM.com

fixed alerts:

1 for Unused import

liat-grozovik · 2021-09-29T08:28:59Z

@neethajohn kindly reminder for the review

qiluo-msft · 2021-12-21T07:46:12Z

Please resolve the conflicts.

…wd_asym_pfc_202012 Conflicts: orchagent/pfcactionhandler.cpp

lgtm-com · 2021-12-28T10:37:10Z

This pull request fixes 1 alert when merging 220cc0e into 9008a01 - view on LGTM.com

fixed alerts:

1 for Unused import

liat-grozovik · 2021-12-30T10:34:07Z

/azp run Azure.sonic-swss

azure-pipelines · 2021-12-30T10:34:17Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2022-01-02T15:04:45Z

/azp run Azure.sonic-swss

azure-pipelines · 2022-01-02T15:04:54Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2022-01-02T15:05:10Z

/azp run LGTM

azure-pipelines · 2022-01-02T15:05:15Z

No pipelines are associated with this pull request.

liat-grozovik · 2022-01-05T18:31:46Z

/azp run

azure-pipelines · 2022-01-05T18:31:56Z

Azure Pipelines successfully started running 1 pipeline(s).

…wd_asym_pfc_202012

lgtm-com · 2022-01-12T11:00:40Z

This pull request fixes 1 alert when merging 5e93a16 into 0b120fa - view on LGTM.com

fixed alerts:

1 for Unused import

…om upstream Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>

lgtm-com · 2022-01-13T09:10:54Z

This pull request fixes 1 alert when merging 57f7d79 into 0b120fa - view on LGTM.com

fixed alerts:

1 for Unused import

prsunny · 2022-01-13T15:35:44Z

/azp run

azure-pipelines · 2022-01-13T15:35:55Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2022-01-16T06:30:27Z

@neethajohn could you please help to review?

liat-grozovik requested a review from neethajohn September 2, 2021 06:35

volodymyrsamotiy force-pushed the pfcwd_asym_pfc_202012 branch from 21c0f04 to 89cf1a2 Compare September 14, 2021 09:22

[202012][PFCWD + Asym PFC]: Allow PFCWD to detect PFC storm on all pr…

48973be

…iorities when Asym PFC is enabled Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>

volodymyrsamotiy force-pushed the pfcwd_asym_pfc_202012 branch from 89cf1a2 to 48973be Compare September 14, 2021 13:32

Merge branch '202012' of https://github.com/Azure/sonic-swss into pfc…

eedaf66

…wd_asym_pfc_202012

zhangyanzhao mentioned this pull request Dec 8, 2021

[202012][Z9332][Pfcwd + Asym Pfc]: With Asym PFC enabled and when pfcwd storm is detected on priority P3 and P4 in a port , PFC packets egress out only for one Priority sonic-net/sonic-buildimage#9453

Open

Merge branch '202012' of https://github.com/Azure/sonic-swss into pfc…

220cc0e

…wd_asym_pfc_202012 Conflicts: orchagent/pfcactionhandler.cpp

Merge branch '202012' of https://github.com/Azure/sonic-swss into pfc…

5e93a16

…wd_asym_pfc_202012

[202012][PFCWD + Asym PFC]: Fix compilation issue after last merge fr…

57f7d79

…om upstream Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>

volodymyrsamotiy closed this Feb 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[202012][PFCWD + Asym PFC]: Allow PFCWD to detect PFC storm on all pr… #1887

[202012][PFCWD + Asym PFC]: Allow PFCWD to detect PFC storm on all pr… #1887

volodymyrsamotiy commented Aug 26, 2021

lgtm-com bot commented Aug 26, 2021

liat-grozovik commented Aug 30, 2021

liat-grozovik commented Sep 2, 2021

volodymyrsamotiy commented Sep 3, 2021

lgtm-com bot commented Sep 3, 2021

liat-grozovik commented Sep 3, 2021

liat-grozovik commented Sep 12, 2021

liat-grozovik commented Sep 12, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

volodymyrsamotiy commented Sep 20, 2021

mssonicbld commented Sep 20, 2021

azure-pipelines bot commented Sep 20, 2021

volodymyrsamotiy commented Sep 27, 2021

mssonicbld commented Sep 27, 2021

azure-pipelines bot commented Sep 27, 2021

lgtm-com bot commented Sep 27, 2021

liat-grozovik commented Sep 29, 2021

qiluo-msft commented Dec 21, 2021

lgtm-com bot commented Dec 28, 2021

liat-grozovik commented Dec 30, 2021

azure-pipelines bot commented Dec 30, 2021

liat-grozovik commented Jan 2, 2022

azure-pipelines bot commented Jan 2, 2022

liat-grozovik commented Jan 2, 2022

azure-pipelines bot commented Jan 2, 2022

liat-grozovik commented Jan 5, 2022

azure-pipelines bot commented Jan 5, 2022

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 13, 2022

prsunny commented Jan 13, 2022

azure-pipelines bot commented Jan 13, 2022

liat-grozovik commented Jan 16, 2022

[202012][PFCWD + Asym PFC]: Allow PFCWD to detect PFC storm on all pr… #1887

[202012][PFCWD + Asym PFC]: Allow PFCWD to detect PFC storm on all pr… #1887

Conversation

volodymyrsamotiy commented Aug 26, 2021

lgtm-com bot commented Aug 26, 2021

liat-grozovik commented Aug 30, 2021

liat-grozovik commented Sep 2, 2021

volodymyrsamotiy commented Sep 3, 2021

lgtm-com bot commented Sep 3, 2021

liat-grozovik commented Sep 3, 2021

liat-grozovik commented Sep 12, 2021

liat-grozovik commented Sep 12, 2021

lgtm-com bot commented Sep 14, 2021

lgtm-com bot commented Sep 14, 2021

volodymyrsamotiy commented Sep 20, 2021

mssonicbld commented Sep 20, 2021

azure-pipelines bot commented Sep 20, 2021

volodymyrsamotiy commented Sep 27, 2021

mssonicbld commented Sep 27, 2021

azure-pipelines bot commented Sep 27, 2021

lgtm-com bot commented Sep 27, 2021

liat-grozovik commented Sep 29, 2021

qiluo-msft commented Dec 21, 2021

lgtm-com bot commented Dec 28, 2021

liat-grozovik commented Dec 30, 2021

azure-pipelines bot commented Dec 30, 2021

liat-grozovik commented Jan 2, 2022

azure-pipelines bot commented Jan 2, 2022

liat-grozovik commented Jan 2, 2022

azure-pipelines bot commented Jan 2, 2022

liat-grozovik commented Jan 5, 2022

azure-pipelines bot commented Jan 5, 2022

lgtm-com bot commented Jan 12, 2022

lgtm-com bot commented Jan 13, 2022

prsunny commented Jan 13, 2022

azure-pipelines bot commented Jan 13, 2022

liat-grozovik commented Jan 16, 2022