[gearbox] Add gearbox unit test #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Sep 21, 2021
| @@ -236,7 +236,7 @@ def __init__( | |||
| name: str = None, | |||
| imgname: str = None, | |||
| keeptb: bool = False, | |||
| fakeplatform: str = None, | |||
| env: list = [], | |||
There was a problem hiding this comment.
what is the reason to change to a list?
There was a problem hiding this comment.
List type, in case multiple environment variables
There was a problem hiding this comment.
The parameter environment of self.client.containers.run is a list type
lguohan
reviewed
Sep 21, 2021
| self.phys[i]["lanes"] = {} | ||
| for j in lane_list: | ||
| (status, fvs) = lane_table.get(j) | ||
| assert status == True |
There was a problem hiding this comment.
Do not need. In dvs creation, it has verified all services ready. The table GEARBOX_TABLE in APP_DB has been created at one time by gearsyncd. In case some error happens, the assertion statements are enough.
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/Azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
* Add DVS_ENV for module specific dvs env variables
jimmyzhai
force-pushed
the
test_gearbox
branch
from
5ccf341 to
f68db68
Compare
lguohan
approved these changes
Sep 30, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
* Add test_gearbox * Add DVS_ENV for module specific dvs env variables
5 tasks
vaibhavhd
added a commit
to vaibhavhd/sonic-swss
that referenced
this pull request
Oct 7, 2021
This reverts commit d23924f.
vaibhavhd
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Oct 9, 2021
[Submodule advance sonic-swss] Include below commits to master image: Cache routes for single nexthop for faster retrieval sonic-net/sonic-swss#1922 Reduce route count for route perf test (sonic-net/sonic-swss#1928) [pytest]: Re-use DVS container when possible (sonic-net/sonic-swss#1816) [PORTSYNCD] when no ports on config db on init, continue and set Port… (sonic-net/sonic-swss#1861) [gearbox] Add gearbox unit test (sonic-net/sonic-swss#1920) Reverted skipped test_buffer_dynamic test cases (sonic-net/sonic-swss#1937) Revert "[buffer orch] Bugfix: Don't query counter SAI_BUFFER_POOL_STA… (sonic-net/sonic-swss#1945)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
How I verified it
Details if related