[AclOrch] move ACL counters to flex counter infrastructure #1943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
This pull request introduces 1 alert when merging 4eef944 into da49332 - view on LGTM.com new alerts:
|
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
This was referenced Oct 6, 2021
|
@bingwang-ms can you please help review? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
reviewed
Oct 18, 2021
bingwang-ms
reviewed
Oct 18, 2021
bingwang-ms
reviewed
Oct 18, 2021
bingwang-ms
reviewed
Oct 18, 2021
|
Reviewed and added several comments. Thanks |
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
bingwang-ms
previously approved these changes
Oct 19, 2021
|
The change LGTM now. Thanks |
|
This pull request introduces 1 alert and fixes 1 when merging f422612 into e14a071 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
This pull request introduces 1 alert and fixes 1 when merging f6d7881 into 70da9af - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
|
This pull request fixes 1 alert when merging 5d670fa into fe5b2a9 - view on LGTM.com fixed alerts:
|
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
|
This pull request fixes 1 alert when merging 8365820 into 05c7c05 - view on LGTM.com fixed alerts:
|
bingwang-ms
approved these changes
Nov 10, 2021
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Nov 15, 2021
#### What I did Made a change for aclshow and counterpoll that adds support for ACL flex counters. DEPENDS ON: sonic-net/sonic-swss-common#533 sonic-net/sonic-sairedis#953 sonic-net/sonic-swss#1943 HLD: sonic-net/SONiC#857 #### How I did it Modified aclshow and counterpoll and UT. #### How to verify it Together with depends PRs. Run ACL/Everflow test suite.
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
What I did Moved the "populate_mock" method to dump/helper.py i.e. common to all the tests Moved the "add_to_ret_template" to Executor class i.e. common across all the modules. How I did it How to verify it Unit Tests's:
Merged
5 tasks
ZhaohuiS
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
May 9, 2022
#5616) What is the motivation for this PR? We can't get acl counters from redis COUNTERS_DB due to this RP sonic-net/sonic-swss#1943. test_acl_outer_vlan.py keeps failing because of the error Failed: Failed to retrieve acl counter for DATAACL_ingress_ipv6|rule_1. How did you do it? Parse the output of aclshow to get counters. How did you verify/test it? run acl/test_acl_outer_vlan.py Signed-off-by: Zhaohui Sun <zhaohuisun@microsoft.com>
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
#### What I did Made a change for aclshow and counterpoll that adds support for ACL flex counters. DEPENDS ON: sonic-net/sonic-swss-common#533 sonic-net/sonic-sairedis#953 sonic-net/sonic-swss#1943 HLD: sonic-net/SONiC#857 #### How I did it Modified aclshow and counterpoll and UT. #### How to verify it Together with depends PRs. Run ACL/Everflow test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added ACL Flex Counter group. Re-implemented ACL counters implemention to work with Flex Counter Infrastructure.
Why I did it
To improve orchagent performance when large amount of ACL rules are configured.
How I verified it
Together with depends PRs. Run ACL/Everflow test suite.
Details if related
DEPENDS ON: sonic-net/sonic-swss-common#533 sonic-net/sonic-sairedis#953
HLD: sonic-net/SONiC#857