-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cbf] Add class-based forwarding support #1963
Conversation
This pull request introduces 1 alert when merging cf32453 into f248e26 - view on LGTM.com new alerts:
|
HLD here: sonic-net/SONiC#796 |
Few high-level comments:
|
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
I've moved most of the new files into a subdirectory. I've reduced changes where sensible so that moved code is as easy to see as possible. But to take advantage of being able to reuse code between the two types of next hop groups, a bunch of it has to move (e.g. to templates) |
This pull request introduces 1 alert when merging cd49fff into 6b15584 - view on LGTM.com new alerts:
|
This is too much of code churn for this feature. If its new, why modify lots of existing code unless it was not originally designed correctly. IMO, this is re-reviewing the code and not sure if this can be made to 202111 |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request introduces 1 alert when merging e048b3a into d95823d - view on LGTM.com new alerts:
|
Based on discussion:
|
@prsunny I've made those suggested changes. The changes to the original nhgorch now mostly consist of the following:
All these changes are now a lot easier to follow in the code, as there's less churn |
/azpw run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
@prsunny are you happy for this to merge now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed common code and lgtm.
* [cbf] Added initial CBF support (#2) * Added CBF NHG support to NhgOrch * Added NhgMapOrch to handle DSCP_TO_FC and EXP_TO_FC tables * Added UT for the new NhgOrch function and NhgMapOrch Support sonic-net/SONiC#796 Co-authored-by: Alexandru Banu <v-albanu@microsoft.com>
…et#1963) What I did Add soft-reboot command support for the armhf and arm64 platforms How I did it Add logic to retrieve kernel boot arguments from the Device Tree rather than from the GRUB config for these platforms How to verify it Execute the soft-reboot command on an armhf or arm64 platform
What I did
Why I did it
Support sonic-net/SONiC#796
How I verified it
SWSS UTs covering new functionality