Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant calls to get child scheduler group during initialization #1965

Merged
merged 3 commits into from
Nov 17, 2021

Commits on Oct 29, 2021

  1. Remove redundant calls to get child scheduler group during initializa…

    …tion
    
    The QoS orchagent call SAI APIs to get the number of child scheduler groups
    and then initialize them.
    After that, the size of child scheduler groups vector will be non-zero,
    which indicates the child scheduler groups have been initialized and
    prevent QoS orchagent from calling SAI APIs.
    However, on Mellanox platform, some scheduler groups don't have child group,
    leaving size of child scheduler groups always being zero.
    This causes QoS orchagent to call the SAI API each time the scheduler group
    is handled, which wastes a lot of time especially during fast reboot.
    
    An extra flag indicating whether the child groups have been initialized
    is introduced to avoid the redundant calls.
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    70478e5 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. Fix review comments

    - Fix compiling errors in ARM
    - Remove some redundant log message
    
    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    8e7c34f View commit details
    Browse the repository at this point in the history
  2. Remove yet another redundant log message

    Signed-off-by: Stephen Sun <stephens@nvidia.com>
    stephenxs committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    3ead084 View commit details
    Browse the repository at this point in the history