[vs tests]Migrating sonic-swss tests to use hwsku instead of fakeplatform #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
kcudnik
approved these changes
Oct 25, 2021
|
I think we've fakeplatform check for Vxlan/Vnet tests as well. Do you think making the changes in a single PR is more easier to review and track as these have dependencies. |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merged
5 tasks
prsunny
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Nov 5, 2021
… used (#9175) *Removing fake_platform environment variable. Following the merge of #9044 and sonic-net/sonic-swss#1978 the fake_platform environment variable is not used in any place and removing the stale references. Signed-off-by: Sudharsan Dhamal Gopalarathnam <sudharsand@nvidia.com>
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
- What I did Replace the wrong help message of "Set lossless PGs for the interface" with the right one "Set interface cable length" - How I did it Update the help message to the relevant one on main.py - How to verify it Run the following command: "config interface cable-length Ethernet0 -h" - Previous command output (if the output of a command-line utility has changed) Set lossless PGs for the interface - New command output (if the output of a command-line utility has changed) Set interface cable length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
After adding support for spawning docker-sonic-vs by SKU, the usage of fake_platform needs to be replaced by SKU. Orchagent and SAI will infer the particular platform based on SKU
Why I did it
To add SKU support for vs.
How I verified it
Running tests that depend on platform and ensure they work with new approach of using hwsku.
Details if related