-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reclaiming buffer] Support reclaiming buffer in traditional model #2011
Merged
liat-grozovik
merged 3 commits into
sonic-net:master
from
stephenxs:reclaim-buffer-traditional
Nov 22, 2021
Merged
[Reclaiming buffer] Support reclaiming buffer in traditional model #2011
liat-grozovik
merged 3 commits into
sonic-net:master
from
stephenxs:reclaim-buffer-traditional
Nov 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's to port the changes in 201911 to master Signed-off-by: Stephen Sun <stephens@nvidia.com>
keboliu
previously approved these changes
Nov 15, 2021
@stephenxs , can you please add a vs test for this change? |
hi @neethajohn
|
neethajohn
reviewed
Nov 16, 2021
Signed-off-by: Stephen Sun <stephens@nvidia.com>
neethajohn
approved these changes
Nov 16, 2021
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
Nov 22, 2021
5 tasks
4 tasks
This was referenced Dec 3, 2021
liat-grozovik
pushed a commit
that referenced
this pull request
Dec 7, 2021
…buffer model (#2063) - What I did It's to port #2011 to 202012 To reclaim reserved buffer. As the way to do it differs among vendors, buffermgrd will: 1. Handle port admin down on Mellanox platform. - Not apply lossless buffer PG to an admin-down port - Remove lossless buffer PG (3-4) from a port when it is shut down. 2. Read lossless buffer PG (3-4) to a port when a port is started up. - Why I did it To support reclaiming reserved buffer when a port is shut down on Mellanox platform in traditional buffer model. - How I verified it Regression test and vs test. Signed-off-by: Stephen Sun stephens@nvidia.com
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Fix the ro command rw permission required issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
It's to port #1837 to master.
To reclaim reserved buffer.
As the way to do it differs among vendors,
buffermgrd
will:Signed-off-by: Stephen Sun stephens@nvidia.com
Why I did it
To support reclaiming reserved buffer when a port is shut down on Mellanox platform in traditional buffer model.
How I verified it
sonic-mgmt test and vs test.
Details if related