Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routed subinterface enhancements #2017

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Conversation

preetham-singh
Copy link
Contributor

@preetham-singh preetham-singh commented Nov 9, 2021

Moving swss-common subinterface library(PR #529) to swss library as per subinterface enhancement HLD update.

What I did
Routed subinterfae enhancements HLD #833
Add support for long name and short name routed subinterfaces.
Add support for long name and short name routed subinterfaces.
This swss common library provides APIS for:

  • Subinterface validation checks
  • Get parent interface corresponding to subinterface(short/long name)
  • Get subinterface index

Why I did it
Routed subinterface feature was broken for physical and portchannel subinterfaces for subinterface name exceeding 15 characters due to kernel limitation of netdev name length of 15.

How I verified it
Routed subinterface Unit tests

Support for long name and short name routed subinterfaces
This swss common library provides APIS for:
- Performs Subinterface validation checks
- Get parent interface corresponding to subinterface(short/long name)
- Get subinterface index
@preetham-singh
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

preetham-singh added a commit to preetham-singh/sonic-swss that referenced this pull request Nov 12, 2021
1. use statedb PORT_TABLE and statedb LAG_TABLE to get
admin and mtu on front panel and port channel interfaces.
Portsyncd and teamsyncd now updates admin and MTU status of
corresponding netdev to statedb PORT_TABLE and LAG_TABLE.
2. Subinterface library moved to swss/lib as part of PR sonic-net#2017. Makefile
and header inclusion changes updates accordingly.
@preetham-singh
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@preetham-singh
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Collaborator

prsunny commented Nov 12, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny merged commit 8b5a401 into sonic-net:master Nov 15, 2021
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
…t#1951)"" (sonic-net#2019)

Refer to sonic-net#1951 for details

The PR sonic-net#1951 was reverted in sonic-net#2016 because it was thought to be causing the build failure in sonic-swss TestWarmReboot UTs. But it seems the failures in TestWarmReboot are still occurring e.g. sonic-net#2017 [build](https://dev.azure.com/mssonic/build/_build/results?buildId=65653&view=logs&s=859b8d9a-8fd6-5a5c-6f5e-f84f1990894e)

I think we can reapply sonic-net#1951 and need to investigate TestWarmReboot tests instability
preetham-singh added a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
1. use statedb PORT_TABLE and statedb LAG_TABLE to get
admin and mtu on front panel and port channel interfaces.
Portsyncd and teamsyncd now updates admin and MTU status of
corresponding netdev to statedb PORT_TABLE and LAG_TABLE.
2. Subinterface library moved to swss/lib as part of PR sonic-net#2017. Makefile
and header inclusion changes updates accordingly.
preetham-singh added a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
1. use statedb PORT_TABLE and statedb LAG_TABLE to get
admin and mtu on front panel and port channel interfaces.
Portsyncd and teamsyncd now updates admin and MTU status of
corresponding netdev to statedb PORT_TABLE and LAG_TABLE.
2. Subinterface library moved to swss/lib as part of PR sonic-net#2017. Makefile
and header inclusion changes updates accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants