[muxorch] Bind all ports to drop ACL table #2027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
prsunny
reviewed
Nov 16, 2021
| acl_table.stage = ACL_STAGE_INGRESS; | ||
| gAclOrch->addAclTable(acl_table); | ||
| bindAllPorts(acl_table); |
There was a problem hiding this comment.
As you can see from line 783, the same table shall be used if pfcwd has already created this table. You may want to apply the same fix here as well -
There was a problem hiding this comment.
Sure. I can update the PR with requested changes. But cisco platform does not use drop ACL for PFC wd so I won't be able to verify it. Is it fine to change?
There was a problem hiding this comment.
ok, then leave it for now and revisit later
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Nov 19, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
BInd all physical ports to drop ACL table
Why I did it
With current implementation, ACL table is link/bind to the very first port that triggers creation of drop ACL table followed by rule creation for the same.
For subsequent ports only new rule is created.
If a port is not linked/bind to the drop ACL table, the rule is not applied for that port.
How I verified it
Details if related