Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Buffer] Fix the bug that buffer configuration will cause failed logs during warm restart. #2085

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steven-guo-ec
Copy link

  • What I do:
    Let BufferMgr not execute the entries which are already in APPL_DB after a warm restart.

  • Why I did it:
    After warm start, the BufferMgr will set entries into APPL_DB which already exist.
    It will cause bufferorch to do a modification event.
    But, currently, modifying the buffer configuration is not supported in SAI, and it will print error messages.
    The error messages will cause test cases to fail.

  • How I verify it:
    With this enhancement, the syslog will not appear the error messages about Buffer during a warm restart.

…arm restart.

Signed-off-by: Steven Guo <steven_guo@edge-core.com>
@stephenxs
Copy link
Collaborator

@steven-guo-ec
can you please elaborate on which buffer attributes are not supported in SAI?
IMO buffer orch will not set create-only attributes

@prsunny
Copy link
Collaborator

prsunny commented Jan 26, 2022

Please add VS tests

@steven-guo-ec
Copy link
Author

SAI_BUFFER_POOL_ATTR_SIZE and SAI_BUFFER_PROFILE_ATTR_BUFFER_SIZE is not supported to set after they were created, they can be configured only when creating them.

@stephenxs
Copy link
Collaborator

SAI_BUFFER_POOL_ATTR_SIZE and SAI_BUFFER_PROFILE_ATTR_BUFFER_SIZE is not supported to set after they were created, they can be configured only when creating them.

Thanks. But this does not comply with SAI definition. Check SAI_BUFFER_POOL_ATTR_SIZE and SAI_BUFFER_PROFILE_ATTR_RESERVED_BUFFER_SIZE for details.
So IMO this should be fixed by vendor SAI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants