Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OA changes to support Ordered ECMP and DVS test for same. #2092

Merged
merged 5 commits into from
Jan 13, 2022

Conversation

abdosi
Copy link
Contributor

@abdosi abdosi commented Dec 28, 2021

What I did:-

  • Orchagent changes to support Ordered ECMP as per design Order ECMP HLD. SONiC#896
  • While testing Order ECMP for Overlay ECMP use case found that for single nexthop based tunnel we create route without checking BFD state for endpoint. This results in not needed transaction of add_route followed by del_route.

How I verify:-

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@abdosi abdosi requested a review from prsunny as a code owner December 28, 2021 01:04
@abdosi abdosi requested a review from shi-su December 28, 2021 01:04
@lgtm-com
Copy link

lgtm-com bot commented Dec 28, 2021

This pull request fixes 1 alert when merging 3ec64d0 into 691c37b - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@@ -10,6 +10,7 @@

#define SWITCH_CAPABILITY_TABLE_PORT_TPID_CAPABLE "PORT_TPID_CAPABLE"
#define SWITCH_CAPABILITY_TABLE_LAG_TPID_CAPABLE "LAG_TPID_CAPABLE"
#define SWITCH_CAPABILITY_ORDERED_ECMP_CAPABLE "ORDERED_ECMP_CAPABLE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be named SWITCH_CAPABILITY_TABLE_ORDERED_ECMP_CAPABLE for better consistency?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
shi-su
shi-su previously approved these changes Jan 6, 2022
@lgtm-com
Copy link

lgtm-com bot commented Jan 7, 2022

This pull request fixes 1 alert when merging 9322837 into 691c37b - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@abdosi
Copy link
Contributor Author

abdosi commented Jan 11, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 11, 2022

This pull request fixes 1 alert when merging e5a958c into 6dae6b8 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

shi-su
shi-su previously approved these changes Jan 11, 2022
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
@lgtm-com
Copy link

lgtm-com bot commented Jan 12, 2022

This pull request fixes 1 alert when merging 8931ec4 into 8fd6e48 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@abdosi
Copy link
Contributor Author

abdosi commented Jan 12, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented Jan 12, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented Jan 12, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi abdosi merged commit c78aa1b into sonic-net:master Jan 13, 2022
@abdosi abdosi deleted the ordered_ecmp branch January 13, 2022 04:02
dprital pushed a commit to dprital/sonic-swss that referenced this pull request May 8, 2022
…2092)

What I did:-

Orchagent changes to support Ordered ECMP as per design Order ECMP HLD. SONiC#896
While testing Order ECMP for Overlay ECMP use case found that for single nexthop based tunnel we create route without checking BFD state for endpoint. This results in not needed transaction of add_route followed by del_route.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
…2092)

What I did:-

Orchagent changes to support Ordered ECMP as per design Order ECMP HLD. SONiC#896
While testing Order ECMP for Overlay ECMP use case found that for single nexthop based tunnel we create route without checking BFD state for endpoint. This results in not needed transaction of add_route followed by del_route.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants