-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OA changes to support Ordered ECMP and DVS test for same. #2092
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This pull request fixes 1 alert when merging 3ec64d0 into 691c37b - view on LGTM.com fixed alerts:
|
orchagent/switchorch.h
Outdated
@@ -10,6 +10,7 @@ | |||
|
|||
#define SWITCH_CAPABILITY_TABLE_PORT_TPID_CAPABLE "PORT_TPID_CAPABLE" | |||
#define SWITCH_CAPABILITY_TABLE_LAG_TPID_CAPABLE "LAG_TPID_CAPABLE" | |||
#define SWITCH_CAPABILITY_ORDERED_ECMP_CAPABLE "ORDERED_ECMP_CAPABLE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be named SWITCH_CAPABILITY_TABLE_ORDERED_ECMP_CAPABLE
for better consistency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This pull request fixes 1 alert when merging 9322837 into 691c37b - view on LGTM.com fixed alerts:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request fixes 1 alert when merging e5a958c into 6dae6b8 - view on LGTM.com fixed alerts:
|
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This pull request fixes 1 alert when merging 8931ec4 into 8fd6e48 - view on LGTM.com fixed alerts:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…2092) What I did:- Orchagent changes to support Ordered ECMP as per design Order ECMP HLD. SONiC#896 While testing Order ECMP for Overlay ECMP use case found that for single nexthop based tunnel we create route without checking BFD state for endpoint. This results in not needed transaction of add_route followed by del_route. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
…2092) What I did:- Orchagent changes to support Ordered ECMP as per design Order ECMP HLD. SONiC#896 While testing Order ECMP for Overlay ECMP use case found that for single nexthop based tunnel we create route without checking BFD state for endpoint. This results in not needed transaction of add_route followed by del_route. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
What I did:-
add_route
followed bydel_route
.How I verify:-
true
andfalse
.