[tunnelmgrd]: Warm boot support #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
reviewed
Mar 4, 2022
cfgmgr/tunnelmgr.h
Outdated
|
|
||
| std::map<std::string, TunnelInfo > m_tunnelCache; | ||
| std::map<std::string, IpPrefix> m_intfCache; | ||
| std::string m_peerIp; | ||
|
|
||
| std::set<std::string> m_tunnelReplay; | ||
| bool replayDone; |
There was a problem hiding this comment.
Looks like initialization is missing. Assign default to 'false' here.
cfgmgr/tunnelmgr.cpp
Outdated
| @@ -191,6 +210,13 @@ void TunnelMgr::doTask(Consumer &consumer) | |||
| ++it; | |||
| } | |||
| } | |||
|
|
|||
| if (!replayDone && | |||
There was a problem hiding this comment.
Prefer to keep in one line for this. This will help controlling the number of lines in the file growing quickly.
- Initialize variable - Reduce line count Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
previously approved these changes
Mar 9, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
approved these changes
Mar 16, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 21, 2022
* [tunnelmgrd]: Warm boot support Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
dprital
pushed a commit
to dprital/sonic-swss
that referenced
this pull request
May 8, 2022
* [tunnelmgrd]: Warm boot support Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
* [tunnelmgrd]: Warm boot support Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
What I did
Add warmboot support to tunnelmgrd
Why I did it
During warmboot, tunnelmgrd initiates a write to APP_DB for an IPinIP tunnel which already exists in hardware prior to the warmboot. This causes an orchagent crash.
How I verified it
Run the new tunnelmgrd warmboot test
Details if related