Removing Vnet with scope default #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
Apr 26, 2022
qiluo-msft
pushed a commit
that referenced
this pull request
Apr 26, 2022
* [Vnetorch] Delete vnet vrf object when scope is not default
5 tasks
|
@sumukhatv @prsunny This is also needed for 202111 branch. Can you please cherrypick? |
judyjoseph
pushed a commit
that referenced
this pull request
May 8, 2022
* [Vnetorch] Delete vnet vrf object when scope is not default
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
* [Vnetorch] Delete vnet vrf object when scope is not default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
If VirtualRouter ID is the default value, then don' remove it.
Why I did it
When removing Vnet with scope
default, we need not remove the Vrf object if it is of default value.How I verified it
Added tests to verify it
Details if related