-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202012][cherry-pick] Support tunnel traffic QoS remapping #2246
[202012][cherry-pick] Support tunnel traffic QoS remapping #2246
Conversation
Signed-off-by: bingwang <bingwang@microsoft.com>
Signed-off-by: bingwang <bingwang@microsoft.com>
Signed-off-by: bingwang <wang.bing@microsoft.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: bingwang <wang.bing@microsoft.com>
Signed-off-by: bingwang <bingwang@microsoft.com>
This pull request introduces 2 alerts when merging 47914af into cfed8c7 - view on LGTM.com new alerts:
|
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@@ -246,7 +251,7 @@ sai_object_id_t DscpToTcMapHandler::addQosItem(const vector<sai_attribute_t> &at | |||
} | |||
SWSS_LOG_DEBUG("created QosMap object:%" PRIx64, sai_object); | |||
|
|||
applyDscpToTcMapToSwitch(SAI_SWITCH_ATTR_QOS_DSCP_TO_TC_MAP, sai_object); | |||
//applyDscpToTcMapToSwitch(SAI_SWITCH_ATTR_QOS_DSCP_TO_TC_MAP, sai_object); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if pcbb is not enabled, we need this function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. If pcbb is enabled, do we need to set SAI_TUNNEL_ATTR_DECAP_QOS_DSCP_TO_TC_MAP
for other IPinIP tunnel except for Mux tunnel?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge this PR for now, and fix this issue in another PR.
Signed-off-by: bingwang bingwang@microsoft.com
What I did
This PR is to cherry-pick #2190 into
202012
branch after resolving conflicts.This PR is to update
orchagent
to support tunnel traffic remapping.HLD sonic-net/SONiC#950
Changes include
tunneldecaporch
to apply new SAI attributes to tunnelmuxorch
to apply new SAI attributes to tunnelqosorch
to parse new QoS map tablesWhy I did it
Please check HLD sonic-net/SONiC#950 for more details.
How I verified it
Verified by vs test
System test is work in progress.
Details if related