[muxorch] Handling optional attributes in muxorch #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I did: Added soc_ipv4 and cable_type as optional attributes in muxorch. Why I did it: cable_type field in MUX_CABLE table was throwing parse errors How I did it: adding soc_ipv4 and cable_type wo mux_cfg_request_description Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
vdahiya12
approved these changes
May 24, 2022
lolyu
approved these changes
May 25, 2022
6 tasks
yxieca
pushed a commit
that referenced
this pull request
May 27, 2022
What I did: Added soc_ipv4 and cable_type as optional attributes in muxorch. Why I did it: cable_type field in MUX_CABLE table was throwing parse errors How I did it: adding soc_ipv4 and cable_type wo mux_cfg_request_description Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
What I did: Added soc_ipv4 and cable_type as optional attributes in muxorch. Why I did it: cable_type field in MUX_CABLE table was throwing parse errors How I did it: adding soc_ipv4 and cable_type wo mux_cfg_request_description Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did: Added soc_ipv4 and cable_type as optional attributes in muxorch.
Why I did it: cable_type field in MUX_CABLE table was throwing parse errors
How I did it: adding soc_ipv4 and cable_type wo mux_cfg_request_description
Signed-off-by: Nikola Dancejic ndancejic@microsoft.com