Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ACL table fails due to incorrect check for supported ACL actions #2351

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Create ACL table fails due to incorrect check for supported ACL actions #2351

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions orchagent/aclorch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ static const acl_capabilities_t defaultAclActionsSupported =
}
};

static acl_table_action_list_lookup_t defaultAclActionList =
static acl_table_action_list_lookup_t defaultAclActionList =
{
{
// L3
Expand Down Expand Up @@ -326,7 +326,7 @@ static acl_table_action_list_lookup_t defaultAclActionList =
// The match fields for certain ACL table type are not exactly the same between INGRESS and EGRESS.
// For example, we can only match IN_PORT for PFCWD table type at INGRESS.
// Hence we need to specify stage particular matching fields in stageMandatoryMatchFields
static acl_table_match_field_lookup_t stageMandatoryMatchFields =
static acl_table_match_field_lookup_t stageMandatoryMatchFields =
{
{
// TABLE_TYPE_PFCWD
Expand Down Expand Up @@ -2045,7 +2045,7 @@ bool AclTable::addMandatoryActions()
// Add the default action list
for (auto action : defaultAclActionList[type.getName()][stage])
{
if (m_pAclOrch->isAclActionSupported(stage, acl_action))
if (m_pAclOrch->isAclActionSupported(stage, action))
{
SWSS_LOG_INFO("Added default action for table type %s stage %s",
type.getName().c_str(),
Expand Down