[DualToR] Handle race condition between tunnel_decap and mux orchestrator #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
approved these changes
Jul 26, 2022
|
thanks @devpatha for the quick turnaround. |
yxieca
pushed a commit
that referenced
this pull request
Jul 28, 2022
…ator (#2397) *Change orch list to make sure mux_orch and mux_cb_orch are placed after tunnel_decap_orch
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
…ator (sonic-net#2397) *Change orch list to make sure mux_orch and mux_cb_orch are placed after tunnel_decap_orch
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Change orch list to make sure mux_orch and mux_cb_orch are placed after tunnel_decap_orch
Why I did it
handlePeerSwitch returns false because mux tunnel not yet created, and that results in create_nh_tunnel failure.
This moves ports into error state.
How I verified it
Verified that after changing the order ports don't move to error state.
Details if related
Creating a new PR for #2113
PR #2114 has already been merged into 202012 branch