Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FDB] [202012] Fix fbdorch to properly handle syncd FDB FLUSH Notif #2401

Merged
merged 3 commits into from
Aug 16, 2022

Commits on Jul 29, 2022

  1. [FDB] Fix fbdorch to properly handle syncd FDB FLUSH Notif (sonic-net…

    …#2254)
    
    Vlan delete couldn't be handled by OA when there is fdb learnt on the member and when the member is deleted
    This inability of handling APPL_DB notif is affecting warm-restart. FDB Entry from State DB is not removed.
    OA doesn't have the logic to handle consolidate flush notif coming from syncd
    FdbOrch doesn't have logic to clear internal cache and decrement corresponding fdb counters during a flush notification
    
    Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
    vivekrnv committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    7d8af09 View commit details
    Browse the repository at this point in the history
  2. [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353)

    - What I did
    using a copy of FDBEntry fields (stored in FDBUpdate) instead of a reference since the reference gets invalidated in the storeFdbEntryState()
    simplified clearFdbEntry() interface
    
    - Why I did it
    To fix the memory usage issue
    The issue is that the SWSS_LOG_INFO() uses the mac&, port_alias&, and bv_id& which are invalidated in the storeFdbEntryState().
    
    - How I verified it
    Run the tests that were used to find the issues and checked the ASAN report
    
    Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
    Yakiv-Huryk authored and vkarri committed Jul 29, 2022
    Configuration menu
    Copy the full SHA
    ed50d20 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. Configuration menu
    Copy the full SHA
    0de0d1c View commit details
    Browse the repository at this point in the history