[EVPN]Modified tunnel creation logic when creating tunnel in VRF-VNI map creation flow #2404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…map creation flow During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI. Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map
…tunnel is not supported 2) Modified the tunnel counter polling interval to 10000 ms by default
|
This pull request fixes 1 alert when merging 86f3ec3 into 3161eaa - view on LGTM.com fixed alerts:
|
prsunny
approved these changes
Aug 4, 2022
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dgsudharsan shoudl it be taken to otehr branches or master only? |
|
@liat-grozovik Request for 202205. |
yxieca
pushed a commit
that referenced
this pull request
Aug 8, 2022
…map creation flow (#2404) Same as PR #2387 - What I did To fix issue sonic-net/sonic-buildimage#11428 Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow. Modified the tunnel stats interval to 10 sec Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported - Why I did it During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI. - How I verified it Modified UT to add VRF-VNI map first and VLAN-VLAN map later
7 tasks
lukasstockner
pushed a commit
to genesiscloud/sonic-swss
that referenced
this pull request
Mar 31, 2023
…map creation flow (sonic-net#2404) Same as PR sonic-net#2387 - What I did To fix issue sonic-net/sonic-buildimage#11428 Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow. Modified the tunnel stats interval to 10 sec Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported - Why I did it During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI. - How I verified it Modified UT to add VRF-VNI map first and VLAN-VLAN map later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as PR #2387
What I did
To fix issue sonic-net/sonic-buildimage#11428
Modified the logic of tunnel map creation to create tunnel with tunnel map for vlan-vni map in addition to vrf-vni map when tunnel is created first time in the VRF-VNI map processing flow.
Modified the tunnel stats interval to 10 sec
Modified the logic to create bridge port for p2mp tunnel only when p2p tunnel is not supported
Why I did it
During the configuration phase when VRF-VNI map arrives before VLAN-VNI map, the tunnel is created without a tunnel map for vlan-vni membership. This is problematic when VLAN to VNI map arrives later, tunnel map entry cannot be created since the tunnel map doesn't exist and its a create only attribute in SAI.
How I verified it
Modified UT to add VRF-VNI map first and VLAN-VLAN map later
Details if related