[QoS] Enforce drop probability only for colors whose WRED are enabled #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
remove-enforce-wred-drop
branch
from
40cb96f
to
238488f
Compare
Signed-off-by: Stephen Sun <stephens@nvidia.com>
|
@stephenxs it is for master only or a bug fix for 202205? |
|
@neethajohn , @prsunny could you please help to review and signoff? |
keboliu
approved these changes
Sep 14, 2022
neethajohn
approved these changes
Sep 14, 2022
7 tasks
stephenxs
added a commit
to stephenxs/sonic-swss
that referenced
this pull request
Sep 19, 2022
…sonic-net#2422) What I did Do not enforce drop probability for a color whose WRED is disabled. Signed-off-by: Stephen Sun stephens@nvidia.com Why I did it Currently, there is a logic to enforce the drop probability if it is not explicitly designated for a color. However, the drop probability is not a mandatory attribute. It can incur vendor SAI complaints to set it when the color is disabled. The logic was introduced from the very beginning (by PR sonic-net#571) because no drop probability was defined in the QoS template at the time, which is no longer true. So we will enforce drop probability only if it is not configured and the color is enabled. How I verified it Unit test and manual test
7 tasks
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-swss
that referenced
this pull request
Sep 21, 2022
…hose WRED are enabled (sonic-net#2422)
yxieca
pushed a commit
that referenced
this pull request
Sep 21, 2022
…#2422) What I did Do not enforce drop probability for a color whose WRED is disabled. Signed-off-by: Stephen Sun stephens@nvidia.com Why I did it Currently, there is a logic to enforce the drop probability if it is not explicitly designated for a color. However, the drop probability is not a mandatory attribute. It can incur vendor SAI complaints to set it when the color is disabled. The logic was introduced from the very beginning (by PR #571) because no drop probability was defined in the QoS template at the time, which is no longer true. So we will enforce drop probability only if it is not configured and the color is enabled. How I verified it Unit test and manual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Do not enforce drop probability for a color whose WRED is disabled.
Signed-off-by: Stephen Sun stephens@nvidia.com
Why I did it
Currently, there is a logic to enforce the drop probability if it is not explicitly designated for a color. However, the drop probability is not a mandatory attribute. It can incur vendor SAI complaints to set it when the color is disabled.
The logic was introduced from the very beginning (by PR #571) because no drop probability was defined in the QoS template at the time, which is no longer true.
So we will enforce drop probability only if it is not configured and the color is enabled.
How I verified it
Unit test and manual test
Details if related