New P4Orch development. #2425
Merged
New P4Orch development. #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prsunny |
|
Hi @prsunny, can you please take a look? |
|
@prsunny |
prsunny
reviewed
Nov 3, 2022
| class ResponsePublisherInterface { | ||
| public: | ||
| virtual ~ResponsePublisherInterface() = default; | ||
| class ResponsePublisherInterface |
There was a problem hiding this comment.
looks like this file is not changed but added with some tabspace? Do you want to revert this?
There was a problem hiding this comment.
We ran clang-format using Microsoft style. This matches other p4orch codes and the SONiC codes.
I think we should make this change to keep the style consistent.
I can create a different PR for this if you need. Otherwise, we can keep the change here.
Change-Id: Ia2328c148068e60bb8eef57c41c55286806be680
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
previously approved these changes
Nov 4, 2022
prsunny
approved these changes
Nov 9, 2022
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream new development on p4orch:
Co-authored-by: Runming Wu runmingwu@google.com
Co-authored-by: Yilan Ji yilanji@google.com
Co-authored-by: Manali Kumar manalikumar@google.com