[neighsyncd] Enabling ipv4 link local entries for non-dualtor #2427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow ipv4 link local entries to be programmed to the hardware unless on a dual-tor setup. fixing sonic-net/sonic-buildimage#11830 Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
prsunny
reviewed
Aug 24, 2022
| @@ -431,12 +431,12 @@ def test_Ipv4LinkLocalNeighbor(self, dvs, testlog): | |||
| # check application database | |||
| tbl = swsscommon.Table(self.pdb, "NEIGH_TABLE:Ethernet8") | |||
| intf_entries = tbl.getKeys() | |||
| assert len(intf_entries) == 0 | |||
| assert len(intf_entries) == 1 | |||
There was a problem hiding this comment.
Can we add a test to cover dualtor case?
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
|
This pull request fixes 1 alert when merging d91e336 into 4aaeec9 - view on LGTM.com fixed alerts:
|
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
|
This pull request fixes 1 alert when merging 424aa4a into 4aaeec9 - view on LGTM.com fixed alerts:
|
dgsudharsan
approved these changes
Aug 29, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Aug 30, 2022
yxieca
pushed a commit
that referenced
this pull request
Sep 1, 2022
* [neighsyncd] Enabling ipv4 link local entries for non-dualtor Allow ipv4 link local entries to be programmed to the hardware unless on a dual-tor setup.
dprital
added a commit
to dprital/sonic-buildimage
that referenced
this pull request
Sep 1, 2022
Update sonic-swss submodule pointer to include the following: * [BFD]Clean up state_db BFD entries on swss restart ([sonic-net#2434](sonic-net/sonic-swss#2434)) * Fix the Fec Mode Setting of gbsyncd ([sonic-net#2430](sonic-net/sonic-swss#2430)) * [neighsyncd] Enabling ipv4 link local entries for non-dualtor ([sonic-net#2427](sonic-net/sonic-swss#2427)) * tlm_teamd: Filter portchannel subinterface events from STATE_DB LAG_TABLE ([sonic-net#2408](sonic-net/sonic-swss#2408)) * PFCWD recovery changes using DLR_INIT ([sonic-net#2316](sonic-net/sonic-swss#2316)) * Dynamic port configuration - add port buffer cfg to the port ref counter ([sonic-net#2194](sonic-net/sonic-swss#2194)) Signed-off-by: dprital <drorp@nvidia.com>
This was referenced Sep 1, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow ipv4 link local entries to be programmed to the hardware unless on
a dual-tor setup.
fixing sonic-net/sonic-buildimage#11830
Signed-off-by: Nikola Dancejic ndancejic@microsoft.com