[tests] [asan] extend graceful stop flag to also stop syncd #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, when running DVS tests with --graceful-stop, both swss and syncd are stopped via SIGTERM. This is needed for asan to generate reports. Signed-off-by: Yakiv Huryk <yhuryk@nvidia.com>
|
@xumia kindly reminder to review this pr |
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xumia
approved these changes
Oct 30, 2022
liat-grozovik
approved these changes
Nov 8, 2022
liat-grozovik
approved these changes
Nov 8, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Extended DVS test "--graceful-stop" flag to also stop syncd.
Why I did it
So ASAN can generate reports for syncd.
How I verified it
Run the tests with --graceful-stop, observe that the syncd process is stopped via SIGTERM
Details if related