Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vs test issue: failed to remove vlan due to referenced by vlan interface #2504

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

stephenxs
Copy link
Collaborator

@stephenxs stephenxs commented Nov 1, 2022

What I did

Fix: remove the VLAN interface before removing the VLAN itself

Signed-off-by: Stephen Sun stephens@nvidia.com

Why I did it

There is a logic in VLAN vs test cases test_VlanGratArp and test_VlanProxyArp to create a VLAN, a VLAN interface and then remove the VLAN and then check whether the VLAN is removed from SAI.
However, the step to remove the VLAN interface is missed, which causes the VLAN to be referenced and prevents it from being deleted.

How I verified it

Run vs test.

Details if related

…terface

Fix: remove vlan interface before removing the vlan itself

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stephenxs
Copy link
Collaborator Author

Hi @prsunny
Could you please review this PR? It fixes VLAN vs test issue which blocks other PRs
Thanks

@lolyu
Copy link
Contributor

lolyu commented Nov 22, 2022

@prsunny @stephenxs @yxieca Added request for 202205 as the test_vlan.py suffers from the same issue.

yxieca pushed a commit that referenced this pull request Nov 29, 2022
…terface (#2504)

*Fix: remove vlan interface before removing the vlan itself
@stephenxs stephenxs deleted the fix-vlan-vs-test branch December 26, 2022 08:33
lolyu added a commit that referenced this pull request Jan 4, 2023
What I did
Cherry-pick back #2469 into 202205.

Why I did it
It is reverted in 202205: #2518 because of the flakiness of test_vlan.py

How I verified it
This depends on the following PRs:
#2504
#2541
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants