Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fdbsyncd] Bug Fix for remote to local MAC and Static MAC Adv in EVPN #2521

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

kishorekunal01
Copy link
Contributor

- What I did
On local MAC learning, update the MAC entry as local then delete the DST entry from the Kernel for remote MAC. This will make sure that FRR doesn't reinstall the remote MAC(#12363)
When installing the static MAC in the kernel set the sticky flag as well. (#12419)

- How I did it
Move the DST entry delete code after the MAC update code.(#12363)
Pass sticky flag to the kernel in fdbsyncd code.((#12419)

- How to verify it
Tested MAC move from remote to local and verified the MAC is local in Kernel.(#12363)
Verified in Kernel that sticky bit is set and the same as advertised by FRR in the network.(#12419)

Signed-off-by: kishore.kunal@broadcom.com

…c MAC advertisement in EVPN.

    - What I did
    On local MAC learning, update the MAC entry as local then delete the DST entry from the Kernel for remote MAC. This will make sure that FRR doesn't reinstall the remote MAC(#12363)
    When installing the static MAC in the kernel set the sticky flag as well. (#12419)

    - How I did it
    Move the DST entry delete code after the MAC update code.(#12363)
    Pass sticky flag to the kernel in fdbsyncd code.((#12419)

    - How to verify it
    Tested MAC move from remote to local and verified the MAC is local in Kernel.(#12363)
    Verified in Kernel that sticky bit is set and the same as advertised by FRR in the network.((#12419)

Signed-off-by: kishore.kunal@broadcom.com
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 15, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: kishorekunal01 / name: KISHORE KUNAL (127d8f2)

@prsunny prsunny requested a review from dgsudharsan November 15, 2022 02:06
@marian-pritsak marian-pritsak merged commit dca78d8 into sonic-net:master Nov 18, 2022
dgsudharsan pushed a commit to dgsudharsan/sonic-swss that referenced this pull request Nov 22, 2022
…c MAC advertisement in EVPN. (sonic-net#2521)

- What I did
    On local MAC learning, update the MAC entry as local then delete the DST entry from the Kernel for remote MAC. This will make sure that FRR doesn't reinstall the remote MAC(#12363)
    When installing the static MAC in the kernel set the sticky flag as well. (#12419)

    - How I did it
    Move the DST entry delete code after the MAC update code.(#12363)
    Pass sticky flag to the kernel in fdbsyncd code.((#12419)

    - How to verify it
    Tested MAC move from remote to local and verified the MAC is local in Kernel.(#12363)
    Verified in Kernel that sticky bit is set and the same as advertised by FRR in the network.((#12419)

Signed-off-by: kishore.kunal@broadcom.com
yxieca pushed a commit that referenced this pull request Nov 29, 2022
…c MAC advertisement in EVPN. (#2521)

- What I did
    On local MAC learning, update the MAC entry as local then delete the DST entry from the Kernel for remote MAC. This will make sure that FRR doesn't reinstall the remote MAC(#12363)
    When installing the static MAC in the kernel set the sticky flag as well. (#12419)

    - How I did it
    Move the DST entry delete code after the MAC update code.(#12363)
    Pass sticky flag to the kernel in fdbsyncd code.((#12419)

    - How to verify it
    Tested MAC move from remote to local and verified the MAC is local in Kernel.(#12363)
    Verified in Kernel that sticky bit is set and the same as advertised by FRR in the network.((#12419)

Signed-off-by: kishore.kunal@broadcom.com
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Dec 28, 2022
Update sonic-swss submodule pointer to include the following:
* 782a2ef Align watermark flow with port configuration ([sonic-net#2525](sonic-net/sonic-swss#2525))
* dca78d8 [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. ([sonic-net#2521](sonic-net/sonic-swss#2521))
* 28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message ([sonic-net#2492](sonic-net/sonic-swss#2492))

Signed-off-by: dprital <drorp@nvidia.com>
liat-grozovik pushed a commit to sonic-net/sonic-buildimage that referenced this pull request Dec 29, 2022
Update sonic-swss submodule pointer to include the following:
* 782a2ef Align watermark flow with port configuration ([#2525](sonic-net/sonic-swss#2525))
* dca78d8 [Fdbsyncd] Bug Fix for remote MAC move to local MAC and Fix for Static MAC advertisement in EVPN. ([#2521](sonic-net/sonic-swss#2521))
* 28aa309 [fpm] Fix FpmLink to read all netlink messages from FPM message ([#2492](sonic-net/sonic-swss#2492))

Signed-off-by: dprital <drorp@nvidia.com>
lukasstockner pushed a commit to genesiscloud/sonic-swss that referenced this pull request Mar 31, 2023
…c MAC advertisement in EVPN. (sonic-net#2521)

- What I did
    On local MAC learning, update the MAC entry as local then delete the DST entry from the Kernel for remote MAC. This will make sure that FRR doesn't reinstall the remote MAC(#12363)
    When installing the static MAC in the kernel set the sticky flag as well. (#12419)

    - How I did it
    Move the DST entry delete code after the MAC update code.(#12363)
    Pass sticky flag to the kernel in fdbsyncd code.((#12419)

    - How to verify it
    Tested MAC move from remote to local and verified the MAC is local in Kernel.(#12363)
    Verified in Kernel that sticky bit is set and the same as advertised by FRR in the network.((#12419)

Signed-off-by: kishore.kunal@broadcom.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants