[202205][dual-tor] use 'egress' port for Mellanox platform for ACL rules for standby ToR #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Dec 9, 2022
ayurkiv-nvda
force-pushed
the
work_solution_upstream
branch
2 times, most recently
from
078fdbb
to
231defd
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ayurkiv-nvda
force-pushed
the
work_solution_upstream
branch
from
231defd
to
4d557f9
Compare
|
Commenter does not have sufficient privileges for PR 2565 in repo sonic-net/sonic-swss |
ayurkiv-nvda
force-pushed
the
work_solution_upstream
branch
from
4d557f9
to
e154e9e
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ayurkiv-nvda
force-pushed
the
work_solution_upstream
branch
from
e154e9e
to
ff0d27b
Compare
Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
ayurkiv-nvda
force-pushed
the
work_solution_upstream
branch
from
ff0d27b
to
2230766
Compare
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Dec 27, 2022
prsunny
approved these changes
Dec 27, 2022
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Yurkiv ayurkiv@nvidia.com
What I did
For Dual-Tor scenario on standby ports drop packets on the egress stage for mellanox platform only.
Remain old behavior for other platform.
NOTE
Currently, it is short-term solution which will be replaced with more generic one
Why I did it
Current SAI ACL implementation drops both data plane and control-plane traffic if rules are installed on ingress stage.
But DualToR expects only data-plane traffic to be dropped, and control-plane should not be affected.
In order to handle this limitation, we will allow traffic to go into ingress port, then handle control plane traffic and drop that traffic on egress ports
How I verified it
Setup Dual-ToR, both Active and Standby should have "healthy" status
Details if related