Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swss: Fix Invalid port oid messages generated because of voq counters. #2653

Merged
merged 3 commits into from
Feb 23, 2023
Merged

swss: Fix Invalid port oid messages generated because of voq counters. #2653

merged 3 commits into from
Feb 23, 2023

Conversation

skbarista
Copy link
Contributor

@skbarista skbarista commented Feb 3, 2023 •
edited
Loading

What I did

Why I did it

To fix the invalid oids messages generated by CounterCheckOrch for voq.

How I verified it

Verified that the invalid port oid messages go away. Verified voq counters.

@skbarista
swss: Fix Invalid port oid messages generated because of voq counters.
b7e1ec1 
* Do not add Voq oids to CounterCheckOrch since CounterCheckOrch is not
  relevant for voqs.
@skbarista skbarista marked this pull request as draft February 3, 2023 18:45
@skbarista skbarista marked this pull request as ready for review February 3, 2023 22:14
@skbarista
swss: Fix Invalid port oid messages generated because of voq counters.
95a49a3 
* Do not add Voq oids to CounterCheckOrch since CounterCheckOrch is not
  relevant for voqs.
@skbarista
swss: Fix Invalid port oid messages generated because of voq counters.
80a1bb7 
* Do not add Voq oids to CounterCheckOrch since CounterCheckOrch is not
  relevant for voqs.
@judyjoseph judyjoseph mentioned this pull request Feb 9, 2023
Closed
@vmittal-msft
Copy link
Contributor

@skbarista Can you please share queuestat output from chassis as well as ToR system to make sure it is working on both ? Also, Could we check if syslogs are clean for both chassis as well as ToR systems ?

@arlakshm arlakshm mentioned this pull request Feb 15, 2023
Closed
This was referenced Feb 15, 2023
Closed
Closed
@wenyiz2021 wenyiz2021 mentioned this pull request Feb 15, 2023
Merged
6 tasks
@skbarista
Copy link
Contributor Author

skbarista commented Feb 16, 2023 •
edited
Loading

syslog.txt
tor_counters.txt
voq_stat.txt
syslog_tor.txt

@skbarista
Copy link
Contributor Author

@skbarista Can you please share queuestat output from chassis as well as ToR system to make sure it is working on both ? Also, Could we check if syslogs are clean for both chassis as well as ToR systems ?

@vmittal-msft attached the requested files.

@vmittal-msft vmittal-msft self-requested a review February 18, 2023 20:00
vmittal-msft
vmittal-msft suggested changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@vmittal-msft vmittal-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check what these errors are -

Feb 16 16:37:50.544450 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x200051500000001 does not has supported counters
Feb 16 16:37:50.544450 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x201051500000001 does not has supported counters
Feb 16 16:37:50.544500 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x202051500000001 does not has supported counters
Feb 16 16:37:50.544544 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x203051500000001 does not has supported counters
Feb 16 16:37:50.544633 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x204051500000001 does not has supported counters

Also, if we fix the following, Do you think we can fix VoQ counters ? without always enabling them ?

counters
Feb 16 16:37:50.655990 nfc421-5 ERR swss#orchagent: :- getQueueConfigurations: Invalid BUFFER_QUEUE key: [nfc421-8|Asic0|Ethernet64|5-6]
Feb 16 16:37:50.655990 nfc421-5 ERR swss#orchagent: :- getQueueConfigurations: Invalid BUFFER_QUEUE key: [nfc421-5|Asic0|Ethernet24|5-6]
Feb 16 16:37:50.655990 nfc421-5 ERR swss#orchagent: :- getQueueConfigurations: Invalid BUFFER_QUEUE key: [nfc421-8|Asic0|Ethernet108|0-2]
Feb 16 16:37:50.656123 nfc421-5 ERR swss#orchagent: :- getQueueConfigurations: Invalid BUFFER_QUEUE key: [nfc421-5|Asic0|Ethernet172|5-6]
Feb 16 16:37:50.656123 nfc421-5 ERR swss#orchagent: :- getQueueConfigurations: Invalid BUFFER_QUEUE key: [nfc421-8|Asic0|Ethernet20|0-2]
Feb 16 16:37:50.656123 nfc421-5 ERR swss#orchagent: :- getQueueConfigurations: Invalid BUFFER_QUEUE key: [nfc421-8|Asic0|Ethernet168|0-2]
Feb 16 16:37:50.656123 nfc421-5 ERR swss#orchagent: :- getQueueConfigurations: Invalid BUFFER_QUEUE key: [nfc421-5|Asic0|Ethernet176|0-2]

@skbarista
Copy link
Contributor Author

@vmittal-msft these are because getQueueConfigurations does not have code yet to parse voq config as I mentioned in my previous comment.

@skbarista skbarista requested review from vmittal-msft and removed request for prsunny February 21, 2023 18:18
@skbarista
Copy link
Contributor Author

@vmittal-msft just to add the getQueueConfigurations are not related to changes I have made.

@vmittal-msft vmittal-msft removed their request for review February 21, 2023 19:17
@vmittal-msft
Copy link
Contributor

What about these errors ? they seems to be new to me.

Feb 16 16:37:50.544450 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x200051500000001 does not has supported counters
Feb 16 16:37:50.544450 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x201051500000001 does not has supported counters
Feb 16 16:37:50.544500 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x202051500000001 does not has supported counters
Feb 16 16:37:50.544544 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x203051500000001 does not has supported counters
Feb 16 16:37:50.544633 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x204051500000001 does not has supported counters

@skbarista
Copy link
Contributor Author

What about these errors ? they seems to be new to me.

Feb 16 16:37:50.544450 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x200051500000001 does not has supported counters
Feb 16 16:37:50.544450 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x201051500000001 does not has supported counters
Feb 16 16:37:50.544500 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x202051500000001 does not has supported counters
Feb 16 16:37:50.544544 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x203051500000001 does not has supported counters
Feb 16 16:37:50.544633 nfc421-5 NOTICE syncd#syncd: :- addObject: Queue Counter oid:0x204051500000001 does not has supported counters

@vmittal-msft Let me check these and come back

@vmittal-msft vmittal-msft merged commit 35a7ab0 into sonic-net:master Feb 23, 2023
yxieca pushed a commit that referenced this pull request Mar 1, 2023
@skbarista @yxieca
swss: Fix Invalid port oid messages generated because of voq counters. (
9d87ec4 
#2653)

* swss: Fix Invalid port oid messages generated because of voq counters.
* Do not add Voq oids to CounterCheckOrch since CounterCheckOrch is not
  relevant for voqs.
@skbarista skbarista mentioned this pull request Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmittal-msft vmittal-msft vmittal-msft approved these changes

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

Assignees

@vmittal-msft vmittal-msft

@skbarista skbarista

Labels
chassis Included in 202205 Branch Request for 202205 Branch
Projects
SONiC Chassis
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

queue counters are not getting populated for voq systems.
3 participants
@skbarista @vmittal-msft @yxieca