Fixed set admin_status for deleted subintf due to late notification #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprital
previously approved these changes
Feb 8, 2023
|
/azpw run Azure.sonic-swss |
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dprital
reviewed
Mar 13, 2023
GitHub handles it like rename of the file |
dprital
approved these changes
Mar 13, 2023
|
@prsunny , Can you please review ? |
prsunny
approved these changes
Mar 14, 2023
|
@EdenGri please help create separate PR for 202205 branch. |
StormLiangMS
pushed a commit
that referenced
this pull request
Mar 19, 2023
…2659) * Fixed set admin_status for deleted subintf due to late notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Handled a race condition in intfmgrd which tries to immediately apply an admin_status SET notif after a DEL causing it to crash
Why I did it
Ignores errors on the set admin_status command for subinterface when the subinterface state is not OK.
How I verified it
Details if related
This PR reference to older PR that fix the same issue in portmgr: #2431