You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I did
[Ci] Support to build sonic-swss-common
Why I did it
It is to improve the chance to build successful rate on sonic-swss.
It removes the dependency of the build artifacts of sonic-swss-common in sonic-swss, always uses the latest code of the sonic-swss-common to build it.
Let me copy you on the email thread. sonic-swss compilation is failing due to sonic-swss-common package doesn't seem to be latest enough for this to compile. So why do we have such dependency ? and not directly compile to avoid such issues.
Why do we want to start building swss-common instead of downloading artifacts?
The build sonic-swss-common is failed in test stage, it blocks the sonic-swss to use the lastest code, and the sonic-swss cannot be built successfully.
Why do we want to start building swss-common instead of downloading artifacts?
The build sonic-swss-common is failed in test stage, it blocks the sonic-swss to use the lastest code, and the sonic-swss cannot be built successfully. It reduces the dependency to wait for the result of another pipeline.
I consider the two aspects as below, any other thoughts? @theasianpianist
Is the cost to build the sonic-swss-common low. (5min)
Do we want to use the latest sonic-swss-common in sonic-swss?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
[Ci] Support to build sonic-swss-common
Why I did it
It is to improve the chance to build successful rate on sonic-swss.
It removes the dependency of the build artifacts of sonic-swss-common in sonic-swss, always uses the latest code of the sonic-swss-common to build it.
How I verified it
Details if related