Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202205] [flowcounterrouter] Fix the Route remove flow for non-bound prefixes #2701

Closed
wants to merge 1 commit into from

Conversation

vivekrnv
Copy link
Contributor

What I did

Backport #2691 to 202205

Why I did it

How I verified it

Details if related

Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Mar 15, 2023

vtest failures:

Doesn't seem to be related to my changes. Seems this appeared in #2360 (comment) and seemingly fixed by #2350. We might need to cherry-pick #2350 to 2205

Test failures: https://dev.azure.com/mssonic/be1b070f-be15-4154-aade-b1d3bfb17054/_apis/build/builds/234198/logs/83

2023-03-15T21:32:58.7799524Z test_AclRuleAddWithoutTableDefinitionFails failed (1 runs remaining out of 2).
2023-03-15T21:32:58.7800476Z 	<class 'ValueError'>
2023-03-15T21:32:58.7801016Z 	filedescriptor out of range in select()
2023-03-15T21:32:58.7806344Z 	[<TracebackEntry /agent/_work/1/s/tests/conftest.py:1808>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:1787>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:601>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:457>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/models/containers.py:198>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/decorators.py:19>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/exec_api.py:169>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:422>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:137>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:416>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:94>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:66>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:51>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:31>]
2023-03-15T21:32:58.7809808Z test_AclRuleAddWithoutTableDefinitionFails failed; it passed 0 out of the required 1 times.
2023-03-15T21:32:58.7810801Z 	<class 'ValueError'>
2023-03-15T21:32:58.7811321Z 	filedescriptor out of range in select()
2023-03-15T21:32:58.7815671Z 	[<TracebackEntry /agent/_work/1/s/tests/conftest.py:1808>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:1787>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:601>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:457>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/models/containers.py:198>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/decorators.py:19>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/exec_api.py:169>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:422>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:137>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:416>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:94>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:66>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:51>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:31>]
2023-03-15T21:32:58.7819133Z test_MirrorSessionAddModifyAndDelete failed (1 runs remaining out of 2).
2023-03-15T21:32:58.7819871Z 	<class 'ValueError'>
2023-03-15T21:32:58.7820438Z 	filedescriptor out of range in select()
2023-03-15T21:32:58.7825141Z 	[<TracebackEntry /agent/_work/1/s/tests/conftest.py:1808>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:1787>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:601>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:457>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/models/containers.py:198>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/decorators.py:19>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/exec_api.py:169>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:422>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:137>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:416>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:94>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:66>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:51>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:31>]
2023-03-15T21:32:58.7828300Z test_MirrorSessionAddModifyAndDelete failed; it passed 0 out of the required 1 times.
2023-03-15T21:32:58.7829227Z 	<class 'ValueError'>
2023-03-15T21:32:58.7829871Z 	filedescriptor out of range in select()
2023-03-15T21:32:58.7835567Z 	[<TracebackEntry /agent/_work/1/s/tests/conftest.py:1808>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:1775>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:406>, <TracebackEntry /agent/_work/1/s/tests/conftest.py:457>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/models/containers.py:198>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/decorators.py:19>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/exec_api.py:169>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:422>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:137>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/api/client.py:416>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:94>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:66>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:51>, <TracebackEntry /usr/local/lib/python3.8/dist-packages/docker/utils/socket.py:31>]
2023-03-15T21:32:58.7839329Z 
2023-03-15T21:32:58.7839895Z ===End Flaky Test Report===

@liat-grozovik
Copy link
Collaborator

@yxieca could you please check the possibility to cherry pick #2350 to 202205 to unblock this PR from getting in 202205?

@dgsudharsan
Copy link
Collaborator

@liat-grozovik This is already cherry-picked into 202205. So Closing this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants