[aclorch] Fix TODO: use SAI object API to query capabilities #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
volodymyrsamotiy
approved these changes
Apr 19, 2023
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
May 2, 2023
|
@bingwang-ms kindly reminder to review |
|
@liat-grozovik Sorry, I missed this review. Can you please share the PR for supporting query |
|
@bingwang-ms We have it already in sairedis for quite some time - https://github.com/sonic-net/sonic-sairedis/blob/master/lib/sai_redis_interfacequery.cpp#L145. |
bingwang-ms
approved these changes
May 30, 2023
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 20, 2023
…et#2743) - What I did Resolved TODO - Why I did it To resolve TODO - How I verified it Build and run. Verify capabilities written in STATE DB: 127.0.0.1:6379[6]> hgetall "SWITCH_CAPABILITY|switch" ... 13) "ACL_ACTION|PACKET_ACTION" 14) "DROP,FORWARD" ... Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Resolved TODO
Why I did it
To resolve TODO
How I verified it
Build and run. Verify capabilities written in STATE DB:
Details if related