[ASAN]Increasing switch create timeout for ASAN images #2777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleksandrivantsiv
approved these changes
May 16, 2023
oleksandrivantsiv
approved these changes
May 16, 2023
oleksandrivantsiv
approved these changes
May 16, 2023
oleksandrivantsiv
previously approved these changes
May 16, 2023
prsunny
reviewed
May 17, 2023
orchagent/main.cpp
Outdated
| @@ -585,7 +585,13 @@ int main(int argc, char **argv) | |||
| attr.value.u64 = gSwitchId; | |||
| attrs.push_back(attr); | |||
|
|
|||
| auto delay_factor = 1; | |||
|
|
|||
| #ifdef ASAN_ENABLED | |||
There was a problem hiding this comment.
Prefer not use #ifdefs in code. @xumia do you've any suggestions?
oleksandrivantsiv
approved these changes
May 22, 2023
|
@xumia Can you please help to close the review? |
xumia
approved these changes
May 27, 2023
|
@dgsudharsan , can you please update the description as to what was the previous timeout and what is the new value in seconds? |
Done |
StormLiangMS
pushed a commit
that referenced
this pull request
Jun 10, 2023
**What I did** When running ASAN images with low CPU systems, due to the additional overhead associated with ASAN, it results in switch create timeout as seen in logs below. Hence increasing the **switch create timeout to 2x for ASAN builds.** e.g. For regular switch scenario, the timeout will be 120 seconds instead of 60 seconds. ``` Apr 18 20:23:46.749074 arc-switch1004 NOTICE swss#orchagent: :- create: request switch create with context 0 Apr 18 20:23:46.749074 arc-switch1004 NOTICE swss#orchagent: :- allocateNewSwitchObjectId: created SWITCH VID oid:0x21000000000000 for hwinfo: '' Apr 18 20:24:46.816998 arc-switch1004 ERR swss#orchagent: :- wait: SELECT operation result: TIMEOUT on getresponse Apr 18 20:24:46.817243 arc-switch1004 ERR swss#orchagent: :- wait: failed to get response for getresponse Apr 18 20:24:46.817405 arc-switch1004 ERR swss#orchagent: :- create: create status: SAI_STATUS_FAILURE Apr 18 20:24:46.817552 arc-switch1004 ERR swss#orchagent: :- main: Failed to create a switch, rv:-1 ``` **Why I did it** To avoid timeout to create switch when testing ASAN builds with lower CPU systems **How I verified it** Loaded the build with changes and verified no issues are seen
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 20, 2023
**What I did** When running ASAN images with low CPU systems, due to the additional overhead associated with ASAN, it results in switch create timeout as seen in logs below. Hence increasing the **switch create timeout to 2x for ASAN builds.** e.g. For regular switch scenario, the timeout will be 120 seconds instead of 60 seconds. ``` Apr 18 20:23:46.749074 arc-switch1004 NOTICE swss#orchagent: :- create: request switch create with context 0 Apr 18 20:23:46.749074 arc-switch1004 NOTICE swss#orchagent: :- allocateNewSwitchObjectId: created SWITCH VID oid:0x21000000000000 for hwinfo: '' Apr 18 20:24:46.816998 arc-switch1004 ERR swss#orchagent: :- wait: SELECT operation result: TIMEOUT on getresponse Apr 18 20:24:46.817243 arc-switch1004 ERR swss#orchagent: :- wait: failed to get response for getresponse Apr 18 20:24:46.817405 arc-switch1004 ERR swss#orchagent: :- create: create status: SAI_STATUS_FAILURE Apr 18 20:24:46.817552 arc-switch1004 ERR swss#orchagent: :- main: Failed to create a switch, rv:-1 ``` **Why I did it** To avoid timeout to create switch when testing ASAN builds with lower CPU systems **How I verified it** Loaded the build with changes and verified no issues are seen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
When running ASAN images with low CPU systems, due to the additional overhead associated with ASAN, it results in switch create timeout as seen in logs below. Hence increasing the switch create timeout to 2x for ASAN builds. e.g. For regular switch scenario, the timeout will be 120 seconds instead of 60 seconds.
Why I did it
To avoid timeout to create switch when testing ASAN builds with lower CPU systems
How I verified it
Loaded the build with changes and verified no issues are seen
Details if related